output_format_json_quote_64bit_integers new config option [#METR-22950] #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludv1x
changed the title
alexey-milovidov
requested changes
Sep 30, 2016
|
|
||
| If the parameter is true, INSERT operation will skip columns with unknown names from input. | ||
| If the parameter is true (default value), INSERT operation will skip columns with unknown names from input. |
| @@ -14,7 +14,7 @@ namespace DB | |||
| class JSONCompactRowOutputStream : public JSONRowOutputStream | |||
| { | |||
| public: | |||
| JSONCompactRowOutputStream(WriteBuffer & ostr_, const Block & sample_, bool write_statistics_); | |||
| JSONCompactRowOutputStream(WriteBuffer & ostr_, const Block & sample_, bool write_statistics_, bool force_quoting_); | |||
There was a problem hiding this comment.
Let rename force_quoting to force_quoting_64bit_integers everywhere.
Because otherwise developers may think that it will quote all data types (or all numbers).
Long name is no problem.
There was a problem hiding this comment.
On the other hand, parameter with such name is too specific for interface function.
However, I don't have any other suggestions.
There was a problem hiding this comment.
I think, that specific name is Ok.
This was referenced Oct 4, 2016
Closed
blinkov
pushed a commit
that referenced
this pull request
Jun 17, 2020
…#126) (#11738) * literacy checking * ru translation * Update docs/ru/interfaces/http.md Co-authored-by: BayoNet <da-daos@yandex.ru> * Update docs/ru/interfaces/http.md Co-authored-by: BayoNet <da-daos@yandex.ru> * Update docs/ru/interfaces/http.md Co-authored-by: BayoNet <da-daos@yandex.ru> * Update docs/ru/interfaces/http.md Co-authored-by: BayoNet <da-daos@yandex.ru> * Update http.md * Update http.md Co-authored-by: Anna Devyatova <annadevyatova@yandex-team.ru> Co-authored-by: BayoNet <da-daos@yandex.ru> Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru> Co-authored-by: Anna <42538400+adevyatova@users.noreply.github.com> Co-authored-by: Anna Devyatova <annadevyatova@yandex-team.ru>
tonickkozlov
pushed a commit
to tonickkozlov/ClickHouse
that referenced
this pull request
Apr 6, 2022
Merge in PLAT/clickhouse from shaynes/clickhouse-1287-pin-pandas to cf/master * commit '3f13271c02701a1187f9e78f5cc0b9895b07928d': Pin Pandas version for lts branch; 1.3 already requires python-dev Switch to internal llvm mirror
lgbo-ustc
added a commit
to bigo-sg/ClickHouse
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.