Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added separate docker image for unbundled build. Added clang-11, gcc-10 in packager image. Updated packager image to ubuntu 20.04 #13723

Merged
merged 3 commits into from Aug 15, 2020

Conversation

qoega
Copy link
Member

@qoega qoega commented Aug 14, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog

Reverted in #13758

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Added separate docker image for unbundled build. Added clang-11, gcc-10 in packager image. Updated packager image to ubuntu 20.04

Detailed description / Documentation draft:

...

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Aug 14, 2020
cmake \
gdb \
pigz \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pigz is needed for packaging.

@alexey-milovidov alexey-milovidov self-assigned this Aug 14, 2020
@alexey-milovidov
Copy link
Member

Fuzzer: #13750

@alexey-milovidov
Copy link
Member

Integration: #13721

@alexey-milovidov
Copy link
Member

It does not work at all.
The reason is that "unbundled" build does not produce portable binary. And looks like the test run in different container.
No idea why the checks were green in this PR.

I will revert.
But we need to continue, we need this change.

@qoega
Copy link
Member Author

qoega commented Aug 17, 2020

No idea why the checks were green in this PR.

I'll check what happened with docker push task between my commit b74ded3, where it was green and yours c241e42, after which stateless container failed to build. https://clickhouse-test-reports.s3.yandex.net/0/c241e42db015e990760c960a912734e529721657/push_to_dockerhub.html#fail1

@qoega
Copy link
Member Author

qoega commented Aug 17, 2020

  1. The problem with stateless containers etc. is that there are only python3 versions of packages available in 20.04.
  2. Actual problem with successful container build in previous check it it is not sufficient to build containers in correct order. We have to pass image tag explicitly for dependent docker build processes.

=>
We need to make unbundled build without upgrade to 20.04
Transfer python2->python3 blocks ubuntu upgrade for tests containers.

@alexey-milovidov
Copy link
Member

Ok.

@robot-clickhouse robot-clickhouse added pr-not-for-changelog This PR should not be mentioned in the changelog and removed pr-build Pull request with build/testing/packaging improvement labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants