Skip abnormaly small messages in AvroConfluent format #13941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… least the AvroConfluent magic number and the schema id definition.
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Aug 25, 2020
robot-clickhouse
added
pr-improvement
|
There are no tests for this change. But as the change is minor, it's passable. |
Not enough timeout in operations because our CI environment is too chaotic. #14117 |
|
AST fuzzer has found a new issue: #14118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #13710
When using Kafka table engine and AvroConfluent input format, gracefully skip malformed message that do not comply with the minumum requirements of AvroConfluent format and thus, do not include at least the 'magic byte' number and the 'schema identifier'.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Corrected an error in AvroConfluent format that caused the Kafka table engine to stop processing messages when an abnormally small, malformed, message was received.
Detailed description / Documentation draft:
When using Kafka table engine and AvroConfluent input format, gracefully skip malformed message that do not comply with the minumum requirements of AvroConfluent format and thus, do not include at least the 'magic byte' number and the 'schema identifier'.