Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add QueryMemoryLimitExceeded event #14647

Merged
merged 2 commits into from Sep 10, 2020
Merged

Add QueryMemoryLimitExceeded event #14647

merged 2 commits into from Sep 10, 2020

Conversation

fastio
Copy link
Contributor

@fastio fastio commented Sep 9, 2020 •
edited by alexey-milovidov

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add QueryMemoryLimitExceeded event. This closes #14589.

Detailed description / Documentation draft:

Add new event for memory limit exceeded.

@alexey-milovidov alexey-milovidov self-assigned this Sep 9, 2020
@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Sep 9, 2020
azat
azat reviewed Sep 9, 2020
View reviewed changes
Copy link
Collaborator

@azat azat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth adding a test? (via system.query_log, since tests that uses system.events cannot be run in parallel)

@alexey-milovidov
Copy link
Member

Integration tests:

test_adaptive_granularity/test.py::test_version_update_two_nodes

@alesapin - flaky test.

@alexey-milovidov
Copy link
Member

LGTM even without a test.

@alexey-milovidov alexey-milovidov merged commit e65e29d into ClickHouse:master Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azat azat azat left review comments

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New "Query Memory Limit Exceeded" event in system.events
4 participants
@fastio @alexey-milovidov @azat @robot-clickhouse