Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ambiguity in parsing of settings profiles. #15982

Conversation

vitlibar
Copy link
Member

@vitlibar vitlibar commented Oct 14, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Bug Fix

Changelog entry:
Fix ambiguity in parsing of settings profiles: CREATE USER ... SETTINGS profile readonly is now considered as using a profile named readonly, not a setting named profile with the readonly constraint. This fixes #15628

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 14, 2020
@akuzm
Copy link
Contributor

akuzm commented Oct 15, 2020

Perf test broken in master.

@akuzm akuzm merged commit f7f59ca into ClickHouse:master Oct 15, 2020
vitlibar pushed a commit that referenced this pull request Oct 20, 2020
Backport #15982 to 20.10: Fix ambiguity in parsing of settings profiles.
vitlibar pushed a commit that referenced this pull request Oct 20, 2020
Backport #15982 to 20.9: Fix ambiguity in parsing of settings profiles.
vitlibar pushed a commit that referenced this pull request Oct 20, 2020
Backport #15982 to 20.8: Fix ambiguity in parsing of settings profiles.
vitlibar pushed a commit that referenced this pull request Oct 20, 2020
Backport #15982 to 20.7: Fix ambiguity in parsing of settings profiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating user on cluster with read-only profile fails
3 participants