Fix segfault with wrong aggregation in lambdas #16082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
CurtizJ
changed the title
alexey-milovidov
approved these changes
Oct 16, 2020
This was referenced Oct 18, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Oct 18, 2020
CurtizJ
added a commit
that referenced
this pull request
Oct 18, 2020
Backport #16082 to 20.10: Fix segfault with wrong aggregation in lambdas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix segfault in some cases of wrong aggregation in lambdas.
Detailed description / Documentation draft:
Fixes #15981.
Looks like it's the best way to throw exception in case of expression like this
arrayMap(x -> x * sum(x), range(10)), because it's hard to determine it inTreeRewrirwer.