Fixed comparison of DateTime64 with different scales #16952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made DateTime64 a stand-alone type rather than typedef to allow function resolution/deduction based on type. Added tests.
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
changed the title
Also updated other places, like type helpers/dispatchers where DateTime64 was implicitly supported before as Decimal64.
Added std::hash overload Fixed the way aggregate functions work with DateTime64 Added an option for an aggregate function to opt out from DateTime64 support Disable support of DateTime64 for AggregateFunctionSun, since it makes very little sense.
|
|
This was referenced Dec 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 8, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Dec 8, 2020
This was referenced Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made DateTime64 a stand-alone type rather than typedef to allow function resolution/deduction based on type.
Added tests.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect comparison of types
DateTime64with different scales. Fixes #16655...
closes: #16655