New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tuple argument support for argMin and argMax #17359
Conversation
1204624
to
a0c6dd1
Compare
a0c6dd1
to
fe589f3
Compare
4e9715c
to
4a0b6e6
Compare
@Avogar hi, could you look at ClickHouse/dragonbox#2? I suspect that build errors are related with |
Hi, I don't have rights to merge PR in ClickHouse-Extras, you can ask @alexey-milovidov. I had a look at build errors, it seems that splitting argMin(Max) creators to separate file was not enough and the translation unit is still too large. May be you can try to simplify it somehow? |
I tried to run the failed command locally and the build failed on |
8b429a5
to
c3fab0a
Compare
b067d29
to
47a0f4e
Compare
@Avogar Eventually I removed using templates for the tuple argument, and have added extracting of columns on |
Thanks! |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support of tuple argument to
argMin
andargMax
functions.Detailed description / Documentation draft:
This commit adds support of tuple argument (with two elements) to
argMin
andargMax
functions, and for this kind of calls changes return value to the tuple too. This allows to use them inSimpleAggregateFunction
, since the tuple works as a state. Also could be useful for discovering maximum and minimum values from comparisons.