ISSUES-117 support temporary table management #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhang2014
changed the title
zhang2014
force-pushed
the
fix/ISSUES-117
branch
3 times, most recently
from
b9340f0
to
1070e46
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
1070e46
to
bfe48f1
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
0603d07
to
19e7c29
Compare
zhang2014
changed the title
ludv1x
reviewed
Feb 2, 2018
| { | ||
| if (!name_p.parse(pos, database, expected)) | ||
| return false; | ||
| } else { |
ludv1x
reviewed
Feb 2, 2018
| @@ -30,6 +31,9 @@ static ColumnPtr getFilteredDatabases(const ASTPtr & query, const Context & cont | |||
| for (const auto & db : context.getDatabases()) | |||
| column->insert(db.first); | |||
|
|
|||
| std::string temporary_database = ""; | |||
| column->insert(temporary_database); | |||
There was a problem hiding this comment.
Just column->insertDefault() `column->insert(String{})
ludv1x
reviewed
Feb 2, 2018
| CREATE TEMPORARY TABLE temp_tab (number UInt64); | ||
| INSERT INTO temp_tab SELECT number FROM system.numbers LIMIT 1; | ||
| SELECT number FROM temp_tab; | ||
| DROP TEMPORARY TABLE temp_tab; |
There was a problem hiding this comment.
Is the new syntax backwards-compatible with the previous one?
ludv1x
reviewed
Feb 2, 2018
| res_columns[1]->insert(table_name); | ||
| res_columns[2]->insert(iterator->table()->getName()); | ||
| res_columns[3]->insert(static_cast<UInt64>(database->getTableMetadataModificationTime(context, table_name))); | ||
| Tables externalTables = context.getSessionContext().getExternalTables(); |
There was a problem hiding this comment.
Camel case (externalTables) is used only for function names.
ludv1x
reviewed
Feb 2, 2018
| @@ -30,6 +31,9 @@ static ColumnPtr getFilteredDatabases(const ASTPtr & query, const Context & cont | |||
| for (const auto & db : context.getDatabases()) | |||
| column->insert(db.first); | |||
|
|
|||
| std::string temporary_database = ""; | |||
| column->insert(temporary_database); | |||
|
|
|||
| Block block { ColumnWithTypeAndName( std::move(column), std::make_shared<DataTypeString>(), "database" ) }; | |||
There was a problem hiding this comment.
You could also put column temporary into the block.
It allows excluding the temporary database in case of WHERE temporary != 0
ludv1x
reviewed
Feb 2, 2018
| @@ -38,6 +38,10 @@ String InterpreterShowTablesQuery::getRewrittenQuery() | |||
| */ | |||
| context.assertDatabaseExists(database, false); | |||
|
|
|||
| if (query.temporary) { | |||
zhang2014
force-pushed
the
fix/ISSUES-117
branch
3 times, most recently
from
3c4987f
to
02afa74
Compare
ludv1x
reviewed
Feb 2, 2018
| if (s_from.ignore(pos, expected)) | ||
| { | ||
| if (query->temporary) | ||
| throw Exception("Unable to parse FROM,Because the temporary table does not have a database."); |
There was a problem hiding this comment.
Could you add an error code?
I would suggest ErrorCodes::SYNTAX_ERROR, but I am not sure it is a syntax error, it is some kind of user error, and the check should be done in the interpreter.
ludv1x
reviewed
Feb 2, 2018
| @@ -14,7 +14,7 @@ namespace DB | |||
| class ParserShowTablesQuery : public IParserBase | |||
| { | |||
| protected: | |||
| const char * getName() const { return "SHOW TABLES|DATABASES query"; } | |||
| const char * getName() const { return "SHOW [TEMPORARY] TABLES|DATABASES query"; } | |||
There was a problem hiding this comment.
Could you add the full syntax with NOT LIKE ...
ludv1x
reviewed
Feb 2, 2018
| { | ||
| Tables external_tables = context.getSessionContext().getExternalTables(); | ||
|
|
||
| for (auto table = external_tables.begin(); table != external_tables.end(); table++) |
There was a problem hiding this comment.
IMHO it is better to use for-range loop
zhang2014
force-pushed
the
fix/ISSUES-117
branch
2 times, most recently
from
a9d6e66
to
2c3451b
Compare
zhang2014
force-pushed
the
fix/ISSUES-117
branch
from
2c3451b
to
9f66aca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #117
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en