Fixes in ODBC dictionary reload and ODBC bridge reachability #18278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print out actual uri_ argument being used
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
approved these changes
Dec 21, 2020
|
I guess it resolves #14489 |
This was referenced Dec 21, 2020
Merged
Merged
Merged
alexey-milovidov
added a commit
that referenced
this pull request
Dec 21, 2020
Backport #18278 to 20.10: Fixes in ODBC dictionary reload and ODBC bridge reachability
alexey-milovidov
added a commit
that referenced
this pull request
Dec 21, 2020
Backport #18278 to 20.11: Fixes in ODBC dictionary reload and ODBC bridge reachability
alexey-milovidov
added a commit
that referenced
this pull request
Dec 21, 2020
Backport #18278 to 20.12: Fixes in ODBC dictionary reload and ODBC bridge reachability
This was referenced Feb 17, 2021
Merged
alexey-milovidov
added a commit
that referenced
this pull request
Feb 19, 2021
Backport #18278 to 20.8: Fixes in ODBC dictionary reload and ODBC bridge reachability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category:
Changelog entry:
clickhouse-odbc-bridgeprocess is unreachable by server on machines with dual IPv4/IPv6 stack; - Fixed issue when ODBC dictionary updates are performed using malformed queries and/or cause crashes; Possibly closes "clickhouse-odbc-bridge is not responding" during dictionary initialization: program startup sequence problems #14489.Detailed description:
clickhouse-odbc-bridgenow binds to127.0.0.1by default instead oflocalhost, this solves a problem when server tries to connect to::1while the bridge is listening to127.0.0.1whenlocalhostresolves to those addresses.ExternalQueryBuilderinstance stores const-refs to members of enclosing object, and when that object isclone()'ed and the original object is destroyed, the instance ofExternalQueryBuilder, that is stored in the new enclosing object, now refers to the destroyed members and builds queries with garbage in them, accessing the destroyed objects. Fixes now closed Incorrect columns and segfault in odbc external dictionary updates #17215.ReadWriteBufferFromHTTPBase::call(). Fixed.