Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix '#18402 parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour' #18449

Merged
merged 2 commits into from Dec 25, 2020
Merged

Bug fix '#18402 parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour' #18449

merged 2 commits into from Dec 25, 2020

Conversation

vladimir-golovchenko
Copy link
Contributor

@vladimir-golovchenko vladimir-golovchenko commented Dec 24, 2020 •
edited by alexey-milovidov

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Bug Fix

Changelog entry:
Proper support for 12AM in parseDateTimeBestEffort function. This fixes #18402.

Detailed description:

parseDateTimeBestEffort * functions ignore AM abbreviation leads to wrong processing the 12th hour.

Bug reproducing

SELECT
    parseDateTimeBestEffort('2020-02-01 12:10:00 AM') AS am,
    parseDateTimeBestEffort('2020-02-01 12:10:00 PM') AS pm

┌──────────────────am─┬──────────────────pm─┐
│ 2020-02-01 12:10:00 │ 2020-02-01 12:10:00 │
└─────────────────────┴─────────────────────┘

Expected behavior

┌──────────────────am─┬──────────────────pm─┐
│ 2020-02-01 00:10:00 │ 2020-02-01 12:10:00 │
└─────────────────────┴─────────────────────┘

See related bug #18402.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Dec 24, 2020
@vladimir-golovchenko
Copy link
Contributor Author

Related bug: #18402

@vladimir-golovchenko vladimir-golovchenko mentioned this pull request Dec 24, 2020
Closed
@alexey-milovidov alexey-milovidov self-assigned this Dec 24, 2020
@alexey-milovidov
Copy link
Member

I have added the changelog entry.

@alexey-milovidov alexey-milovidov merged commit 230f9b6 into ClickHouse:master Dec 25, 2020
This was referenced Dec 25, 2020
Merged
Merged
Closed
Closed
robot-clickhouse pushed a commit that referenced this pull request Dec 25, 2020
Backport #18449 to 20.11: Bug fix '#18402 parseDateTimeBestEffort sho…
6dd9d41 
…uld not ignore AM abbreviation for 12th hour'
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 25, 2020
Merged
robot-clickhouse pushed a commit that referenced this pull request Dec 25, 2020
Backport #18449 to 20.12: Bug fix '#18402 parseDateTimeBestEffort sho…
8f48e04 
…uld not ignore AM abbreviation for 12th hour'
@robot-clickhouse robot-clickhouse mentioned this pull request Dec 25, 2020
Merged
alexey-milovidov added a commit that referenced this pull request Dec 26, 2020
@alexey-milovidov
Merge pull request #18532 from ClickHouse/backport/20.11/18449
7db9b83 
Backport #18449 to 20.11: Bug fix '#18402 parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour'
alexey-milovidov added a commit that referenced this pull request Dec 26, 2020
@alexey-milovidov
Merge pull request #18533 from ClickHouse/backport/20.12/18449
441e065 
Backport #18449 to 20.12: Bug fix '#18402 parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour'
@vladimir-golovchenko vladimir-golovchenko deleted the fix-AM-abbreviation-handling-for-parseDateTimeBestEffort branch December 28, 2020 10:09
This was referenced Feb 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parseDateTimeBestEffort should not ignore AM abbreviation for 12th hour
3 participants
@vladimir-golovchenko @alexey-milovidov @robot-clickhouse