Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just little better #20978

Merged
merged 4 commits into from Feb 20, 2021
Merged

Just little better #20978

merged 4 commits into from Feb 20, 2021

Conversation

alexey-milovidov
Copy link
Member

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Slightly better code in aggregation.

@robot-clickhouse robot-clickhouse added the pr-performance Pull request with some performance improvements label Feb 19, 2021
@alexey-milovidov alexey-milovidov added the force tests Force test ignoring fast test output. label Feb 20, 2021
@alexey-milovidov
Copy link
Member Author

It makes sense: 10% improvement of group_by_fixed_keys test.

@alexey-milovidov
Copy link
Member Author

0.3% improvement in average across all existing perf tests :)

@alexey-milovidov
Copy link
Member Author

01017_uniqCombined_memory_usage
The query succeeded but the server error '241' was expected.

Looks like we also use less memory.

@alexey-milovidov
Copy link
Member Author

It because operator new is not counted in builds with sanitizers.

@alexey-milovidov alexey-milovidov self-assigned this Feb 20, 2021
@alexey-milovidov alexey-milovidov merged commit 316cdf5 into master Feb 20, 2021
@alexey-milovidov alexey-milovidov deleted the little-better branch February 20, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests Force test ignoring fast test output. pr-performance Pull request with some performance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants