Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppc64le: Fix finding libclang_rt.builtins on Fedora\RHEL\CentOS #22458

Conversation

mastertheknife
Copy link
Contributor

@mastertheknife mastertheknife commented Apr 1, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix Fedora\RHEL\CentOS not finding libclang_rt.builtins on ppc64le
...

Detailed description / Documentation draft:
This is because on Fedora\RHEL\CentOS this library has a different name. CMAKE_SYSTEM_PROCESSOR is ppc64le but the library is called powerpc64le. Clang has a nice feature for this. It can give libgcc or libclang_rt depending on the rtlib option.

[root@removed ~]# cmake --system-information | grep CMAKE_SYSTEM_PROCESSOR
CMAKE_SYSTEM_PROCESSOR "ppc64le"
[root@removed ~]# clang --print-file-name=libclang_rt.builtins-ppc64le.a
libclang_rt.builtins-ppc64le.a
[root@removed ~]# clang --print-libgcc-file-name --rtlib=compiler-rt
/usr/lib64/clang/10.0.1/lib/linux/libclang_rt.builtins-powerpc64le.a

...

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Apr 1, 2021
@alexey-milovidov alexey-milovidov self-assigned this Apr 1, 2021
@alexey-milovidov alexey-milovidov merged commit af9ad59 into ClickHouse:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants