Fix a couple of bugs that may cause replicas to diverge #27808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
alesapin
reviewed
Aug 18, 2021
| startup_event.wait(); | ||
|
|
||
| /// If we don't separate create/start steps, race condition will happen | ||
| /// between the assignment of queue_task_handle and queueTask that use the queue_task_handle. | ||
| background_executor.start(); |
There was a problem hiding this comment.
Because we start it here:
alesapin
approved these changes
Aug 19, 2021
|
Performance changes are unrelated. |
This was referenced Aug 19, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 19, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 19, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 19, 2021
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 19, 2021
tavplubix
added a commit
that referenced
this pull request
Aug 25, 2021
Backport #27808 to 21.8: Fix a couple of bugs that may cause replicas to diverge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix a couple of bugs that may cause replicas to diverge
Detailed description / Documentation draft:
#27529