New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dedicated Mark/Uncompressed cache for skip indices #27961
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -546,6 +546,22 @@ void AsynchronousMetrics::update(std::chrono::system_clock::time_point update_ti | |
} | ||
} | ||
|
||
{ | ||
if (auto index_mark_cache = getContext()->getIndexMarkCache()) | ||
{ | ||
new_values["IndexMarkCacheBytes"] = index_mark_cache->weight(); | ||
new_values["IndexMarkCacheFiles"] = index_mark_cache->count(); | ||
} | ||
} | ||
|
||
{ | ||
if (auto index_uncompressed_cache = getContext()->getIndexUncompressedCache()) | ||
{ | ||
new_values["IndexUncompressedCacheBytes"] = index_uncompressed_cache->weight(); | ||
new_values["IndexUncompressedCacheCells"] = index_uncompressed_cache->count(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. So there are different metrics for bytes/cells/files but same metric for cache misses/hits. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @azat I plan to test this pull request and add them. Also enable them by default. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @azat Yes, it'll be useful. @kitaisreal Great! |
||
} | ||
} | ||
|
||
{ | ||
if (auto mmap_cache = getContext()->getMMappedFileCache()) | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This major performance degradation went unnoticed for two years.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, before this PR, there is no mark/uncompressed cache for secondary indices at all. I don't think it's a degradation.