Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LZ4 stream compression of logs #29219

Merged
merged 5 commits into from
Nov 17, 2021

Conversation

evillique
Copy link
Member

@evillique evillique commented Sep 21, 2021

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add option to compress logs before writing them to a file using LZ4. Closes #23860.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Sep 21, 2021
@evillique
Copy link
Member Author

These changes in Poco are needed: ClickHouse/poco#48

@robot-ch-test-poll4 robot-ch-test-poll4 added the submodule changed At least one submodule changed in this PR. label Sep 21, 2021
@nikitamikhaylov nikitamikhaylov self-assigned this Sep 21, 2021
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2021

CLA assistant check
All committers have signed the CLA.

@evillique evillique force-pushed the log_lz4_streaming branch 5 times, most recently from c1e9145 to dea9d72 Compare October 4, 2021 13:53
@evillique evillique force-pushed the log_lz4_streaming branch 3 times, most recently from 3c52c5a to 4b3dfe2 Compare October 7, 2021 11:43
@evillique evillique force-pushed the log_lz4_streaming branch 2 times, most recently from 7c1a141 to 4d81b35 Compare November 9, 2021 07:53
@evillique evillique force-pushed the log_lz4_streaming branch 3 times, most recently from 78f3f16 to b5dea6f Compare November 10, 2021 23:27
Copy link
Member

@nikitamikhaylov nikitamikhaylov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to create a PR to ClickHouse-Extras and merge it into master

@evillique evillique force-pushed the log_lz4_streaming branch 2 times, most recently from 3414e69 to 303dd46 Compare November 16, 2021 10:02
@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature and removed pr-improvement Pull request with some product improvements labels Nov 16, 2021
@evillique evillique merged commit fc9ef14 into ClickHouse:master Nov 17, 2021
@sevirov
Copy link
Contributor

sevirov commented Dec 11, 2021

Internal documentation ticket: DOCSUP-19959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature submodule changed At least one submodule changed in this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: LZ4 compressed clickhouse logs
6 participants