Transform isNull/isNotNull to IS NULL/IS NOT NULL (for external dbs) #29446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-improvement
alexey-milovidov
approved these changes
Sep 27, 2021
This is required to support queries (like `foo IS NULL`) to external databases (i.e. MySQL). This patch had been submitted separately, due to: - avoid mixing patches - run CI (and update tests references)
azat
force-pushed
the
isNull-isNotNull-format
branch
from
5dcea63
to
2378491
Compare
azat
changed the title
Unrelated, but looks interesting, will take a look later. |
|
|
|
Looks like should be fixed by #29494 |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Oct 21, 2021
After ClickHouse#29446 the following query was "broken": select isNotNull(1)+isNotNull(2) from remote('127.2', system.one) This was also a problem for queries to external storages (i.e. mysql), since it also uses query rewrite, like non-local distributed queries. Fixes: ClickHouse#29446
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Transform
isNull/isNotNulltoIS NULL/IS NOT NULL(for external dbs, i.e. MySQL)Detailed description / Documentation draft:
This is required to support queries (like
foo IS NULL/foo IS NOT NULL) to external databases (i.e. MySQL).This patch had been submitted separately, due to:
NOTE: that it may introduce backward compatibility, but none of users should rely on this anyway (hopefully)