Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak error code in ZooKeeper library for correct expectations from t… #2964

Merged
merged 1 commit into from Aug 27, 2018
Merged

Tweak error code in ZooKeeper library for correct expectations from t… #2964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion dbms/src/Common/ZooKeeper/ZooKeeperImpl.cpp
View file
Open in desktop
Expand Up @@ -1265,7 +1265,9 @@ void ZooKeeper::receiveEvent()
if (!response)
std::terminate();

response->error = ZMARSHALLINGERROR;
/// In case we cannot read the response, we should indicate it as the error of that type
/// when the user cannot assume whether the request was processed or not.
response->error = ZCONNECTIONLOSS;
if (request_info.callback)
request_info.callback(*response);

Expand Down