Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less seeks in compressed buffers #29766

Merged
merged 6 commits into from Oct 7, 2021
Merged

Less seeks in compressed buffers #29766

merged 6 commits into from Oct 7, 2021

Conversation

alesapin
Copy link
Member

@alesapin alesapin commented Oct 5, 2021

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove some redundant seek calls while reading compressed blocks in MergeTree table engines family.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Oct 5, 2021
@kssenii kssenii self-assigned this Oct 5, 2021
@alesapin alesapin added the force tests Force test ignoring fast test output. label Oct 5, 2021
@kssenii
Copy link
Member

kssenii commented Oct 7, 2021

Functional stateless tests (debug) — fail: 1 -- 01622_defaults_for_url_engine -- not related to changes.

Integration tests :

  1. test_dictionaries_dependency_xml -- broken in master right now.
  2. test_merge_tree_s3 and test_storage_s3 -- fixed in May be fix s3 tests #29762. Also checked s3 tests locally on this branch.

@kssenii kssenii merged commit 185d58a into master Oct 7, 2021
@kssenii kssenii deleted the remove_redundant_seeks branch October 7, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
force tests Force test ignoring fast test output. pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants