Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential leak of query_id_holder #29879

Merged
merged 2 commits into from Oct 12, 2021
Merged

Fix potential leak of query_id_holder #29879

merged 2 commits into from Oct 12, 2021

Conversation

amosbird
Copy link
Collaborator

@amosbird amosbird commented Oct 8, 2021

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix potential resource leak of the concurrent query limit of merge tree tables introduced in #19544 .

Detailed description / Documentation draft:
.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 8, 2021
@amosbird
Copy link
Collaborator Author

stress test crash

2128953:2021.10.11 15:12:25.661380 [ 30761 ] {} <Fatal> BaseDaemon: ########################################
2128965:2021.10.11 15:12:25.673320 [ 30761 ] {} <Fatal> BaseDaemon: (version 21.11.1.8375, build id: 6E1FA4D25596F445EA119DDAA2CF9C87AEBF7627) (from thread 2772) (query_id: 95acf9ab-9b02-4514-aaf6-ce746753f382) Received signal Unknown signal (-3)
2128968:2021.10.11 15:12:25.681780 [ 30761 ] {} <Fatal> BaseDaemon: Sanitizer trap.
2128971:2021.10.11 15:12:25.685284 [ 30761 ] {} <Fatal> BaseDaemon: Stack trace: 0xd35a42a 0x1bdead51 0xd31bca6 0xd32866f 0x1bf36d7f 0x1bf3ad7b 0x1bf91186 0x1bef6dd7 0x1c0039f1 0x1c003aff 0x1bfaa5ed 0x1bf7a82c 0x1bfd5470 0x1bfa949c 0x1bfa937f 0x1ca2b4ce 0x1ca2aeb4 0x1cfaef31 0x1cfac54a 0x1db7b0e5 0x1db94116 0x1e96f52c 0x1e96f9c5 0x1ea5ff47 0x1ea5d80c 0x7fe755bdd609 0x7fe755b04293
2129258:2021.10.11 15:12:26.065654 [ 30761 ] {} <Fatal> BaseDaemon: 0.1. inlined from ./obj-x86_64-linux-gnu/../src/Common/StackTrace.cpp:303: StackTrace::tryCapture()
2129266:2021.10.11 15:12:26.066753 [ 30761 ] {} <Fatal> BaseDaemon: 0. ../src/Common/StackTrace.cpp:264: StackTrace::StackTrace() @ 0xd35a42a in /usr/bin/clickhouse
2129470:2021.10.11 15:12:26.326513 [ 30761 ] {} <Fatal> BaseDaemon: 1. ./obj-x86_64-linux-gnu/../base/daemon/BaseDaemon.cpp:400: sanitizerDeathCallback() @ 0x1bdead51 in /usr/bin/clickhouse
2135656:2021.10.11 15:12:29.868530 [ 30761 ] {} <Fatal> BaseDaemon: 2. __sanitizer::Die() @ 0xd31bca6 in /usr/bin/clickhouse
2138562:2021.10.11 15:12:33.044267 [ 30761 ] {} <Fatal> BaseDaemon: 3. ? @ 0xd32866f in /usr/bin/clickhouse
2138606:2021.10.11 15:12:33.160336 [ 30761 ] {} <Fatal> BaseDaemon: 4. ./obj-x86_64-linux-gnu/../src/Access/ContextAccess.cpp:217: DB::ContextAccess::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) const @ 0x1bf36d7f in /usr/bin/clickhouse
2138717:2021.10.11 15:12:33.317946 [ 30761 ] {} <Fatal> BaseDaemon: 5.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/__mutex_base:97: ~lock_guard
2138728:2021.10.11 15:12:33.330740 [ 30761 ] {} <Fatal> BaseDaemon: 5.2. inlined from ../src/Access/ContextAccess.cpp:202: operator()
2138743:2021.10.11 15:12:33.335145 [ 30761 ] {} <Fatal> BaseDaemon: 5. ../contrib/libcxx/include/type_traits:3676: decltype(std::__1::forward<DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&>(fp)(std::__1::forward<std::__1::shared_ptr<DB::EnabledRolesInfo const> const&>(fp0))) std::__1::__invoke<DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&, std::__1::shared_ptr<DB::EnabledRolesInfo const> const&>(DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&, std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) @ 0x1bf3ad7b in /usr/bin/clickhouse
2138784:2021.10.11 15:12:33.357410 [ 30761 ] {} <Fatal> BaseDaemon: 6.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/iterator:1496: std::__1::__wrap_iter<std::__1::function<void (std::__1::shared_ptr<DB::EnabledRolesInfo const> const&)> const*>::operator++()
2138792:2021.10.11 15:12:33.369356 [ 30761 ] {} <Fatal> BaseDaemon: 6.2. inlined from ../src/Access/EnabledRoles.cpp:51: operator()
2138810:2021.10.11 15:12:33.377377 [ 30761 ] {} <Fatal> BaseDaemon: 6. ../contrib/libcxx/include/type_traits:3676: decltype(std::__1::forward<DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&>(fp)()) std::__1::__invoke<DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&>(DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&) @ 0x1bf91186 in /usr/bin/clickhouse
2138906:2021.10.11 15:12:33.458792 [ 30761 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2547: ~function
2138922:2021.10.11 15:12:33.489406 [ 30761 ] {} <Fatal> BaseDaemon: 7. ../base/base/../base/scope_guard.h:44: basic_scope_guard<std::__1::function<void ()> >::~basic_scope_guard() @ 0x1bef6dd7 in /usr/bin/clickhouse
2139109:2021.10.11 15:12:33.760743 [ 30761 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../src/Access/RoleCache.cpp:185: DB::RoleCache::roleRemoved(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) @ 0x1c0039f1 in /usr/bin/clickhouse
2139181:2021.10.11 15:12:33.832561 [ 30761 ] {} <Fatal> BaseDaemon: 9.1. inlined from ./obj-x86_64-linux-gnu/../src/Access/RoleCache.cpp:0: operator()
2139187:2021.10.11 15:12:33.838205 [ 30761 ] {} <Fatal> BaseDaemon: 9. ../contrib/libcxx/include/type_traits:3676: decltype(std::__1::forward<DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&>(fp)(std::__1::forward<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&>(fp0), std::__1::forward<std::__1::shared_ptr<DB::IAccessEntity const> const&>(fp0))) std::__1::__invoke<DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&>(DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&) @ 0x1c003aff in /usr/bin/clickhouse
2139202:2021.10.11 15:12:33.862527 [ 30761 ] {} <Fatal> BaseDaemon: 10.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/iterator:1496: std::__1::__wrap_iter<std::__1::tuple<std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::shared_ptr<DB::IAccessEntity const> > const*>::operator++()
2139206:2021.10.11 15:12:33.869665 [ 30761 ] {} <Fatal> BaseDaemon: 10. ../src/Access/IAccessStorage.cpp:439: DB::IAccessStorage::notify(std::__1::vector<std::__1::tuple<std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::shared_ptr<DB::IAccessEntity const> >, std::__1::allocator<std::__1::tuple<std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::shared_ptr<DB::IAccessEntity const> > > > const&) @ 0x1bfaa5ed in /usr/bin/clickhouse
2139353:2021.10.11 15:12:33.927315 [ 30761 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Access/DiskAccessStorage.cpp:0: DB::DiskAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) @ 0x1bf7a82c in /usr/bin/clickhouse
2139862:2021.10.11 15:12:34.105614 [ 30761 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../src/Access/MultipleAccessStorage.cpp:0: DB::MultipleAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) @ 0x1bfd5470 in /usr/bin/clickhouse
2139957:2021.10.11 15:12:34.162778 [ 30761 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:58: bool DB::(anonymous namespace)::tryCall<DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&)::$_12>(DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&)::$_12 const&) @ 0x1bfa949c in /usr/bin/clickhouse
2140046:2021.10.11 15:12:34.191467 [ 30761 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:353: DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&) @ 0x1bfa937f in /usr/bin/clickhouse
2140088:2021.10.11 15:12:34.225591 [ 30761 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../src/Interpreters/InterpreterDropAccessEntityQuery.cpp:0: DB::InterpreterDropAccessEntityQuery::execute()::$_0::operator()(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) const @ 0x1ca2b4ce in /usr/bin/clickhouse
2140159:2021.10.11 15:12:34.321782 [ 30761 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../src/Interpreters/InterpreterDropAccessEntityQuery.cpp:0: DB::InterpreterDropAccessEntityQuery::execute() @ 0x1ca2aeb4 in /usr/bin/clickhouse
2140517:2021.10.11 15:12:34.501021 [ 30761 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:0: DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) @ 0x1cfaef31 in /usr/bin/clickhouse
2141158:2021.10.11 15:12:34.815527 [ 30761 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:950: DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) @ 0x1cfac54a in /usr/bin/clickhouse
2141177:2021.10.11 15:12:34.883453 [ 30761 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:302: DB::TCPHandler::runImpl() @ 0x1db7b0e5 in /usr/bin/clickhouse
2141205:2021.10.11 15:12:34.967200 [ 30761 ] {} <Fatal> BaseDaemon: 20. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1655: DB::TCPHandler::run() @ 0x1db94116 in /usr/bin/clickhouse
2141208:2021.10.11 15:12:34.993503 [ 30761 ] {} <Fatal> BaseDaemon: 21. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x1e96f52c in /usr/bin/clickhouse
2141214:2021.10.11 15:12:35.019368 [ 30761 ] {} <Fatal> BaseDaemon: 22.1. inlined from ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:1397: std::__1::default_delete<Poco::Net::TCPServerConnection>::operator()(Poco::Net::TCPServerConnection*) const
2141217:2021.10.11 15:12:35.032354 [ 30761 ] {} <Fatal> BaseDaemon: 22.2. inlined from ../contrib/libcxx/include/memory:1658: std::__1::unique_ptr<Poco::Net::TCPServerConnection, std::__1::default_delete<Poco::Net::TCPServerConnection> >::reset(Poco::Net::TCPServerConnection*)
2141221:2021.10.11 15:12:35.041542 [ 30761 ] {} <Fatal> BaseDaemon: 22.3. inlined from ../contrib/libcxx/include/memory:1612: ~unique_ptr
2141230:2021.10.11 15:12:35.059066 [ 30761 ] {} <Fatal> BaseDaemon: 22. ../contrib/poco/Net/src/TCPServerDispatcher.cpp:116: Poco::Net::TCPServerDispatcher::run() @ 0x1e96f9c5 in /usr/bin/clickhouse
2141241:2021.10.11 15:12:35.100330 [ 30761 ] {} <Fatal> BaseDaemon: 23. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:213: Poco::PooledThread::run() @ 0x1ea5ff47 in /usr/bin/clickhouse
2141247:2021.10.11 15:12:35.129194 [ 30761 ] {} <Fatal> BaseDaemon: 24.1. inlined from ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:156: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::assign(Poco::Runnable*)
2141254:2021.10.11 15:12:35.150031 [ 30761 ] {} <Fatal> BaseDaemon: 24.2. inlined from ../contrib/poco/Foundation/include/Poco/SharedPtr.h:208: Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >::operator=(Poco::Runnable*)
2141261:2021.10.11 15:12:35.184585 [ 30761 ] {} <Fatal> BaseDaemon: 24. ../contrib/poco/Foundation/src/Thread_POSIX.cpp:360: Poco::ThreadImpl::runnableEntry(void*) @ 0x1ea5d80c in /usr/bin/clickhouse
2141266:2021.10.11 15:12:35.185799 [ 30761 ] {} <Fatal> BaseDaemon: 25. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
2141269:2021.10.11 15:12:35.186513 [ 30761 ] {} <Fatal> BaseDaemon: 26. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so

KochetovNicolai
KochetovNicolai reviewed Oct 12, 2021
View reviewed changes
src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
@@ -993,47 +993,48 @@ RangesInDataParts MergeTreeDataSelectExecutor::filterPartsByPrimaryKeyAndSkipInd

std::shared_ptr<QueryIdHolder> MergeTreeDataSelectExecutor::checkLimits(
const MergeTreeData & data,
const RangesInDataParts & parts_with_ranges,
const ReadFromMergeTree::AnalysisResult & result,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just RangesInDataParts looked better to me. But ok.

@KochetovNicolai
Copy link
Member

test_dictionaries_dependency_xml - known flaky test

@azat
Copy link
Collaborator

azat commented Oct 12, 2021

test_dictionaries_dependency_xml - known flaky test

Should be fixed in #29928

@KochetovNicolai
Copy link
Member

Stress test (undefined) - npe under msan

../src/Access/ContextAccess.cpp:217:32: runtime error: member access within null pointer of type 'std::shared_ptr<const DB::User>::element_type' (aka 'const DB::User')
    #0 0x1bf36d7e in DB::ContextAccess::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) const obj-x86_64-linux-gnu/../src/Access/ContextAccess.cpp:217:32
    #1 0x1bf3ad7a in DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1::operator()(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) const obj-x86_64-linux-gnu/../src/Access/ContextAccess.cpp:201:9
    #2 0x1bf3ad7a in decltype(std::__1::forward<DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&>(fp)(std::__1::forward<std::__1::shared_ptr<DB::EnabledRolesInfo const> const&>(fp0))) std::__1::__invoke<DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&, std::__1::shared_ptr<DB::EnabledRolesInfo const> const&>(DB::ContextAccess::setUser(std::__1::shared_ptr<DB::User const> const&) const::$_1&, std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3676:1
    #3 0x1bf91185 in std::__1::__function::__policy_func<void (std::__1::shared_ptr<DB::EnabledRolesInfo const> const&)>::operator()(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) const obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2221:16
    #4 0x1bf91185 in std::__1::function<void (std::__1::shared_ptr<DB::EnabledRolesInfo const> const&)>::operator()(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&) const obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2560:12
    #5 0x1bf91185 in DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1::operator()() const obj-x86_64-linux-gnu/../src/Access/EnabledRoles.cpp:52:13
    #6 0x1bf91185 in decltype(std::__1::forward<DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&>(fp)()) std::__1::__invoke<DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&>(DB::EnabledRoles::setRolesInfo(std::__1::shared_ptr<DB::EnabledRolesInfo const> const&, basic_scope_guard<std::__1::function<void ()> >&)::$_1&) obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3676:1
    #7 0x1bef6dd6 in std::__1::__function::__policy_func<void ()>::operator()() const obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2221:16
    #8 0x1bef6dd6 in std::__1::function<void ()>::operator()() const obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2560:12
    #9 0x1bef6dd6 in basic_scope_guard<std::__1::function<void ()> >::invoke() obj-x86_64-linux-gnu/../base/base/../base/scope_guard.h:94:9
    #10 0x1bef6dd6 in basic_scope_guard<std::__1::function<void ()> >::~basic_scope_guard() obj-x86_64-linux-gnu/../base/base/../base/scope_guard.h:44:28
    #11 0x1c0039f0 in DB::RoleCache::roleRemoved(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) obj-x86_64-linux-gnu/../src/Access/RoleCache.cpp:185:1
    #12 0x1c003afe in DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1::operator()(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&) const obj-x86_64-linux-gnu/../src/Access/RoleCache.cpp:146:13
    #13 0x1c003afe in decltype(std::__1::forward<DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&>(fp)(std::__1::forward<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&>(fp0), std::__1::forward<std::__1::shared_ptr<DB::IAccessEntity const> const&>(fp0))) std::__1::__invoke<DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&>(DB::RoleCache::getRole(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_1&, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&) obj-x86_64-linux-gnu/../contrib/libcxx/include/type_traits:3676:1
    #14 0x1bfaa5ec in std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>::operator()(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&) const obj-x86_64-linux-gnu/../contrib/libcxx/include/functional:2560:12
    #15 0x1bfaa5ec in DB::IAccessStorage::notify(std::__1::vector<std::__1::tuple<std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::shared_ptr<DB::IAccessEntity const> >, std::__1::allocator<std::__1::tuple<std::__1::function<void (StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&, std::__1::shared_ptr<DB::IAccessEntity const> const&)>, StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::shared_ptr<DB::IAccessEntity const> > > > const&) obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:440:9
    #16 0x1bf7a82b in DB::DiskAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_4::operator()() const obj-x86_64-linux-gnu/../src/Access/DiskAccessStorage.cpp:532:5
    #17 0x1bf7a82b in basic_scope_guard<DB::DiskAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_4>::invoke() obj-x86_64-linux-gnu/../base/base/../base/scope_guard.h:94:9
    #18 0x1bf7a82b in basic_scope_guard<DB::DiskAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&)::$_4>::~basic_scope_guard() obj-x86_64-linux-gnu/../base/base/../base/scope_guard.h:44:28
    #19 0x1bf7a82b in DB::DiskAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) obj-x86_64-linux-gnu/../src/Access/DiskAccessStorage.cpp:536:1
    #20 0x1bfd546f in DB::MultipleAccessStorage::removeImpl(StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> const&) obj-x86_64-linux-gnu/../src/Access/MultipleAccessStorage.cpp:233:21
    #21 0x1bfa949b in DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&)::$_12::operator()() const obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:352:27
    #22 0x1bfa949b in bool DB::(anonymous namespace)::tryCall<DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&)::$_12>(DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&)::$_12 const&) obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:51:13
    #23 0x1bfa937e in DB::IAccessStorage::tryRemove(std::__1::vector<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag>, std::__1::allocator<StrongTypedef<wide::integer<128ul, unsigned int>, DB::UUIDTag> > > const&) obj-x86_64-linux-gnu/../src/Access/IAccessStorage.cpp:353:13
    #24 0x1ca2b4cd in DB::InterpreterDropAccessEntityQuery::execute()::$_0::operator()(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) const obj-x86_64-linux-gnu/../src/Interpreters/InterpreterDropAccessEntityQuery.cpp:39:28
    #25 0x1ca2aeb3 in DB::InterpreterDropAccessEntityQuery::execute() obj-x86_64-linux-gnu/../src/Interpreters/InterpreterDropAccessEntityQuery.cpp:47:9
    #26 0x1cfaef30 in DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, DB::ReadBuffer*) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:635:32
    #27 0x1cfac549 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:950:30
    #28 0x1db7b0e4 in DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:302:24
    #29 0x1db94115 in DB::TCPHandler::run() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1653:9
    #30 0x1e96f52b in Poco::Net::TCPServerConnection::start() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    #31 0x1e96f9c4 in Poco::Net::TCPServerDispatcher::run() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:115:20
    #32 0x1ea5ff46 in Poco::PooledThread::run() obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    #33 0x1ea5d80b in Poco::ThreadImpl::runnableEntry(void*) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    #34 0x7fe755bdd608 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
    #35 0x7fe755b04292 in __clone (/lib/x86_64-linux-gnu/libc.so.6+0x122292)

@KochetovNicolai KochetovNicolai merged commit c36bb92 into ClickHouse:master Oct 12, 2021
This was referenced Oct 12, 2021
Merged
Merged
Closed
Merged
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 12, 2021
Backport #29879 to 21.9: Fix potential leak of query_id_holder
a6064b4
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 12, 2021
Merged
robot-clickhouse pushed a commit that referenced this pull request Oct 12, 2021
Backport #29879 to 21.10: Fix potential leak of query_id_holder
0a1eba3
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 12, 2021
Merged
KochetovNicolai added a commit that referenced this pull request Oct 13, 2021
@KochetovNicolai
Merge pull request #30058 from ClickHouse/backport/21.10/29879
bc255dc 
Backport #29879 to 21.10: Fix potential leak of query_id_holder
KochetovNicolai added a commit that referenced this pull request Oct 13, 2021
@KochetovNicolai
Merge pull request #30057 from ClickHouse/backport/21.9/29879
498ea36 
Backport #29879 to 21.9: Fix potential leak of query_id_holder
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29879 to 21.8: Fix potential leak of query_id_holder
bbc2826
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Closed
robot-clickhouse pushed a commit that referenced this pull request Oct 13, 2021
Backport #29879 to 21.7: Fix potential leak of query_id_holder
23bff48
@robot-clickhouse robot-clickhouse mentioned this pull request Oct 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KochetovNicolai KochetovNicolai KochetovNicolai approved these changes

Assignees
No one assigned
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@amosbird @KochetovNicolai @azat @robot-clickhouse