New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ZooKeeper path for zero-copy locks for shared data #32061
Changes from 8 commits
827fa51
0f9038e
d409ab0
80ab73c
c8fe1dc
e0a16a4
0e685c1
98bae1b
f0b9a43
c724b07
f390111
0c0bf66
33cbfc8
e6fd4bf
e88b97d
0465aef
2d87f0a
7a3c874
8b331cd
cbdba89
92cb451
91e1ac4
b426cc4
6fcd5a7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -334,6 +334,9 @@ class IMergeTreeDataPart : public std::enable_shared_from_this<IMergeTreeDataPar | |
/// Changes only relative_dir_name, you need to update other metadata (name, is_temp) explicitly | ||
virtual void renameTo(const String & new_relative_path, bool remove_new_dir_if_exists) const; | ||
|
||
/// Cleanup after change part | ||
virtual void cleanupOldName(const String & old_part_name) const; | ||
|
||
/// Makes clone of a part in detached/ directory via hard links | ||
virtual void makeCloneInDetached(const String & prefix, const StorageMetadataPtr & metadata_snapshot) const; | ||
|
||
|
@@ -398,10 +401,14 @@ class IMergeTreeDataPart : public std::enable_shared_from_this<IMergeTreeDataPar | |
/// Returns serialization for column according to files in which column is written in part. | ||
SerializationPtr getSerializationForColumn(const NameAndTypePair & column) const; | ||
|
||
/// Return some uniq string for file | ||
/// Required for distinguish different copies of the same part on S3 | ||
/// Return some uniq string for file. | ||
/// Required for distinguish different copies of the same part on remote FS. | ||
String getUniqueId() const; | ||
|
||
/// Return hardlink count for part. | ||
/// Required for keep data on remote FS when part has shadow copies. | ||
UInt32 getRefCount() const; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Need to clarify that it's not some general-purpose refcount. The name should be something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Renamed to |
||
|
||
protected: | ||
|
||
/// Total size of all columns, calculated once in calcuateColumnSizesOnDisk | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Used only in replicated storage. We don't need it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.