Fix reading of nested tuples #33956
Merged
Fix reading of nested tuples #33956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-clickhouse
added
the
pr-bugfix
| @@ -156,8 +156,15 @@ MutableColumnPtr DataTypeTuple::createColumn() const | |||
|
|
|||
| MutableColumnPtr DataTypeTuple::createColumn(const ISerialization & serialization) const | |||
| { | |||
| const auto & element_serializations = | |||
| assert_cast<const SerializationTuple &>(serialization).getElementsSerializations(); | |||
| const auto * current_serialization = &serialization; | |||
There was a problem hiding this comment.
There are no comments.
I opened SerializationNamed.h and there are no comments either.
alexey-milovidov
approved these changes
Jan 27, 2022
CurtizJ
added
the
pr-must-backport
This was referenced Jan 28, 2022
robot-clickhouse
pushed a commit
that referenced
this pull request
Jan 28, 2022
CurtizJ
added a commit
that referenced
this pull request
Jan 29, 2022
Backport #33956 to 22.1: Fix reading of nested tuples
Felixoid
added
the
pr-backports-created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix crash while reading of nested tuples. Fixes #33838.