Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxsplit argument for splitByChar. #34140

Merged
merged 5 commits into from Feb 6, 2022
Merged

Conversation

taiyang-li
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Maxsplit argument for splitByChar. close #34081

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jan 29, 2022
@taiyang-li taiyang-li changed the title Maxsplit argument for splitByChar. close https://github.com/ClickHouse/ClickHouse/issues/34081 Maxsplit argument for splitByChar. Jan 29, 2022
@kitaisreal kitaisreal self-assigned this Jan 29, 2022
@kitaisreal kitaisreal added the can be tested Allows running workflows for external contributors label Jan 29, 2022
@taiyang-li taiyang-li marked this pull request as ready for review January 30, 2022 01:11
@taiyang-li
Copy link
Contributor Author

Failed tests irrelavent with this pr.

src/Functions/FunctionsStringArray.h Show resolved Hide resolved
src/Functions/FunctionsStringArray.h Outdated Show resolved Hide resolved
src/Functions/FunctionsStringArray.h Outdated Show resolved Hide resolved
src/Functions/FunctionsStringArray.h Outdated Show resolved Hide resolved
@kitaisreal
Copy link
Collaborator

@taiyang-li need to fix fast test.

@taiyang-li
Copy link
Contributor Author

@taiyang-li need to fix fast test.

done

@kitaisreal kitaisreal merged commit 5f43fdb into ClickHouse:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

maxsplit argument for splitByChar
3 participants