Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed group by int16 and Date types on AMD EPYC 7401P machine #3512

Merged
merged 3 commits into from Nov 4, 2018
Merged

fixed group by int16 and Date types on AMD EPYC 7401P machine #3512

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d603cb1
fixed group by int16 and Date types on AMD EPYC 7401P machine
lapkofear Nov 1, 2018
2d565f1
code style fix
lapkofear Nov 1, 2018
00fa7d9
Update Aggregator.cpp
alexey-milovidov Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion dbms/src/Interpreters/Aggregator.cpp
View file
Open in desktop
Expand Up @@ -1475,7 +1475,9 @@ void NO_INLINE Aggregator::mergeDataImpl(
Table & table_src,
Arena * arena) const
{
for (auto it = table_src.begin(); it != table_src.end(); ++it)
Copy link
Contributor Author

@lapkofear lapkofear Nov 1, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the last cycle iteration, calculation of the table_src.end() becomes extremely slow(up to 1s) . for template parameters [with Method = DB::AggregationMethodOneNumber<short unsigned int, HashMapTable<long unsigned int, HashMapCell<long unsigned int, char*, TrivialHash, HashTableNoState>, TrivialHash, HashTableFixedGrower<16>, Allocator<true> > >; Table = HashMapTable<long unsigned int, HashMapCell<long unsigned int, char*, TrivialHash, HashTableNoState>, TrivialHash, HashTableFixedGrower<16>, Allocator<true> >] . Such strange behavior is not reproduced on Intel desktop machines. (On Xeon we did not test this) and on other data types.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could provide branch with logs and they output, because such behavior is really strange for me.

decltype(table_src.end()) end = table_src.end();

for (auto it = table_src.begin(); it != end; ++it)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can write
for (auto it = table_src.begin(), end = table_src.end(); it != end; ++it)
for more convenience.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thank you.

{
decltype(it) res_it;
bool inserted;
Expand Down