Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix replaceRegexpAll #35182

Merged
merged 2 commits into from Mar 11, 2022
Merged

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Mar 10, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Mar 10, 2022
@vdimir vdimir marked this pull request as ready for review March 11, 2022 12:15
@vdimir vdimir changed the title Attempt to fix replaceRegexpAll Fix replaceRegexpAll Mar 11, 2022

if (match.length() == 0)
{
/// Step one character to avoid infinite loop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update a comment.

@alexey-milovidov alexey-milovidov merged commit 38fa55f into ClickHouse:master Mar 11, 2022
@vdimir vdimir deleted the regex-replace-35117 branch March 12, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in replaceRegexpAll
4 participants