Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix caseWithExpression return type deduction #35576

Merged
merged 3 commits into from Mar 25, 2022
Merged

Fix caseWithExpression return type deduction #35576

merged 3 commits into from Mar 25, 2022

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Mar 24, 2022 •
edited

Changelog category (leave one):

  • Bug Fix (user-visible misbehaviour in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed return type deduction for caseWithExpression. The type of the ELSE branch is now correctly taken into account.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

Should fix: #35567

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Mar 24, 2022
@antonio2368 antonio2368 changed the title Fix caseWithExpression return type deduction Fix caseWithExpression return type deduction Mar 24, 2022
@antonio2368 antonio2368 mentioned this pull request Mar 24, 2022
Closed
vdimir
vdimir approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@vdimir vdimir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vdimir vdimir self-assigned this Mar 24, 2022
@vdimir
Copy link
Member

vdimir commented Mar 24, 2022

Seems check TestsBugfixCheck recently added by me don't work in all cases

Notice:  bugfix check: stateless - success: Skipped (no pr-bugfix) Report url: null
Notice:  bugfix check: integration - success: Skipped (no pr-bugfix) Report url: null

I suppose it was run before label was added by bot, will check

@antonio2368
Copy link
Member Author

@Mergifyio update

@antonio2368 antonio2368 merged commit e27a68e into master Mar 25, 2022
@antonio2368 antonio2368 deleted the fix-casewithexpression-type-deduction branch March 25, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdimir vdimir vdimir approved these changes

Assignees

@vdimir vdimir

Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Got wrong result for nested case when expression
3 participants
@antonio2368 @vdimir @robot-clickhouse