Set is_all_data_sent on exceptions too #36816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-not-for-changelog
This will avoid clickhouse-test complains about left queries after the test, like in [1]. [1]: https://s3.amazonaws.com/clickhouse-test-reports/36258/9646487c093a75dc31e3e818417cfad83580b40f/stateful_tests__memory__actions_.html Follow-up for: ClickHouse#36649
azat
force-pushed
the
is_all_data_sent-on-exception
branch
from
39bcd0b
to
d82f2ff
Compare
|
Stress hung due to |
alexey-milovidov
approved these changes
May 1, 2022
Failed, CC @kssenii |
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
May 4, 2022
Before tests can fail if there was implicit reconnect, with queries left, and without referenced PR, it requires manual debugging to know that the reason was reconnect. But the problem is, that the server does send EndOfStream but hanged after, but before removing this query from the system.processes. But after adding is_all_data_sent (ClickHouse#36816, ClickHouse#36767, ClickHouse#36649), clickhouse-test can check queries left only for which server did not sent EndOfStream/Exception. In other words after adding is_all_data_sent, it should not be possible to have queries left in such cases. Reverts: 53be9c5 Reverts: ClickHouse#36587
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
This will avoid clickhouse-test complains about left queries after the
test, like in 1.
Follow-up for: #36649 (cc @alexey-milovidov )