Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix columns number mismatch in cross join #37653

Merged
merged 1 commit into from May 31, 2022
Merged

Fix columns number mismatch in cross join #37653

merged 1 commit into from May 31, 2022

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented May 30, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix columns number mismatch in cross join, close #37561

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-bugfix Pull request with bugfix, not backported by default label May 30, 2022
@vdimir
Copy link
Member Author

vdimir commented May 30, 2022

PullRequestCI / TestsBugfixCheck (pull_request) Failing after 1m — TestsBugfixCheck

Maybe but was introduced after last stable release, will check

@nickitat nickitat self-assigned this May 30, 2022
@vdimir
Copy link
Member Author

vdimir commented May 31, 2022

Stress test (debug, actions) — Hung check failed

DB::LRUFileCache::assertCacheCellsCorrectness

Already fixed #37655

@vdimir vdimir merged commit 2a38fdb into ClickHouse:master May 31, 2022
@vdimir vdimir deleted the cross_join_dup_col_names branch May 31, 2022 15:50
@vdimir
Copy link
Member Author

vdimir commented May 31, 2022

PullRequestCI / TestsBugfixCheck (pull_request) Failing after 1m — TestsBugfixCheck

Failure in release is not table due to UB. Maybe need to switch to debug build in this check

@vdimir vdimir mentioned this pull request Sep 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickitat nickitat nickitat approved these changes

Assignees

@nickitat nickitat

Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash (HashJoin)
3 participants
@vdimir @nickitat @robot-ch-test-poll1