Fix incorrect partition pruning when there is a nullable partition #38946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robot-ch-test-poll
added
the
pr-bugfix
| { | ||
| WriteBufferFromOwnString buf; | ||
| part.partition.serializeText(part.storage, buf, FormatSettings{}); | ||
| LOG_TRACE(&Poco::Logger::get("PartitionPruner"), "Partition {} gets pruned", buf.str()); |
There was a problem hiding this comment.
Not sure we want to have this in logs, but let it be
There was a problem hiding this comment.
It's one per partition. It seems acceptable...
KochetovNicolai
approved these changes
Jul 7, 2022
|
Ok. Did not know we have an option for Nullable partition key :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix incorrect partition pruning when there is a nullable partition. This fixes #38941