Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url-encoded basic auth to fetch avro schema in kafka #38948

Closed
wants to merge 5 commits into from
Closed

url-encoded basic auth to fetch avro schema in kafka #38948

wants to merge 5 commits into from

Conversation

dheerajathrey
Copy link
Contributor

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Kafka connector can fetch avro schema from schema registry with basic authentication using url-encoded credentials

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@robot-ch-test-poll robot-ch-test-poll added the pr-improvement Pull request with some product improvements label Jul 7, 2022
@evillique evillique added the can be tested Allows running workflows for external contributors label Jul 7, 2022
@evillique
Copy link
Member

Is there a way to add a test for this? Maybe in tests/integration/test_storage_kafka?

@kiliangrashoff
Copy link

kiliangrashoff commented Aug 8, 2022 •
edited

Hi @dheerajathrey, are you planning to continue work on this PR? I'm trying to get a ClickHouse deployment to work with Aiven schema registry which uses basic auth, and it would really help when this improvement is added.

@dheerajathrey
Copy link
Contributor Author

@kiliangrashoff I have been busy with other work, I will continue work on this, this week.

@dheerajathrey
Copy link
Contributor Author

@evillique I am facing problem when running integration test locally. Is there a way to trigger an integration test from the CI here?

@dheerajathrey
Copy link
Contributor Author

dheerajathrey commented Aug 29, 2022 •
edited

@evillique
I am facing a problem with running integration tests locally. I explained the problem in detail in this issue. #40612
Do you happen to know if the method of running integration tests locally has changed?

@evillique
Copy link
Member

@evillique I am facing a problem with running integration tests locally. I explained the problem in detail in this issue. #40612 Do you happen to know if the method of running integration tests locally has changed?

I usually use ./runner script as described in tests/integration/README.md

@kiliangrashoff
Copy link

kiliangrashoff commented Dec 7, 2022 •
edited

Hi @dheerajathrey are you still working on this? If not could you explain where you got stuck, maybe we can find someone to help finish this PR. I see that you mentioned you ran into issue #40612 previously, someone replied there it was fixed by PR #41143.

@lesandie
Copy link
Contributor

It would be nice to fix this ❤️

Some workaround but it is not very convenient as security is downgraded:

#32887 (comment)

@ilejn ilejn mentioned this pull request May 8, 2023
Merged
@ilejn
Copy link
Contributor

ilejn commented Jun 12, 2023

Hello @kiliangrashoff , could you help with #49664 review?

@evillique
Copy link
Member

Closed in favor of #49664

@evillique evillique closed this Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evillique evillique evillique left review comments

Assignees

@evillique evillique

Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dheerajathrey @CLAassistant @evillique @kiliangrashoff @lesandie @ilejn @robot-ch-test-poll