Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More metrics for on-disk temporary data #40239

Merged
merged 14 commits into from Aug 26, 2022
Merged

More metrics for on-disk temporary data #40239

merged 14 commits into from Aug 26, 2022

Conversation

vdimir
Copy link
Member

@vdimir vdimir commented Aug 15, 2022 •
edited

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

TODO:

  • Profile Events for ExternalSortCompressedBytes/ExternalSortUncompressedBytes
  • Profile Events for partial_merge_join (for full_sorting_join events for sort are used)
  • ProfileEvents for total sort/agg/join
  • CurrentMetrics

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-feature Pull request with new product feature label Aug 15, 2022
@vdimir vdimir force-pushed the vdimir/tmp-file-metrics branch 3 times, most recently from cc28153 to d28d834 Compare August 17, 2022 10:34
@vdimir vdimir marked this pull request as ready for review August 17, 2022 10:59
@antonio2368 antonio2368 self-assigned this Aug 18, 2022
antonio2368
antonio2368 approved these changes Aug 22, 2022
View reviewed changes
src/Common/TemporaryFile.cpp Outdated Show resolved Hide resolved
src/Interpreters/Aggregator.cpp Outdated Show resolved Hide resolved
@vdimir vdimir merged commit e067629 into ClickHouse:master Aug 26, 2022
@vdimir vdimir deleted the vdimir/tmp-file-metrics branch August 26, 2022 09:28
@RunningXie RunningXie mentioned this pull request Mar 1, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels
pr-feature Pull request with new product feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More metrics for on-disk temporary data
3 participants
@vdimir @antonio2368 @robot-ch-test-poll2