New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ThreadStatus::untracked_memory_limit_increase #40321
Remove ThreadStatus::untracked_memory_limit_increase #40321
Conversation
Timeout was 30 seconds, sadly but this was under UBSan, and query profiler is not available there, but in logs there are messages about flushing system tables, and I'm pretty sure the the IO is culprit |
It looks useless nowadays, because operator new cannot throw MEMORY_LIMIT_EXCEEDED today, and so any code that works on Exception is likely safe. Refs: ClickHouse#40249 Refs: ClickHouse#24483 Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2d90bc1
to
ec2e671
Compare
Indeed an OOM (and
Even though this is BC check, it includes #40249, let's see the logs:
As usual, zero allocations after |
It looks useless nowadays, because operator new cannot throw
MEMORY_LIMIT_EXCEEDED today, and so any code that works on Exception is
likely safe.
Refs: #40249 (cc @KochetovNicolai )
Refs: #24483 (cc @kitaisreal @alexey-milovidov )
Will mark as draft until #40424 will not be resolved
Changelog category (leave one):