Add support for absolute format schema paths. #4158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
force-pushed
the
add-support-for-absolute-format-schema-paths
branch
from
f9c0074
to
7f42775
Compare
vitlibar
commented
Jan 26, 2019
| SELECT 'SYNTAX2->'; | ||
| SELECT * FROM test.table ORDER BY name FORMAT Protobuf SETTINGS format_schema = '00825_protobuf_format_syntax2_copy:Syntax2Person'; | ||
| SELECT * FROM test.table ORDER BY name FORMAT Protobuf SETTINGS format_schema = '$CURDIR/00825_protobuf_format_syntax2:Syntax2Person'; |
There was a problem hiding this comment.
The improvement suggested in this PR allows to simplify this test. Now it's not necessary to copy schema files to the current directory.
vitlibar
force-pushed
the
add-support-for-absolute-format-schema-paths
branch
from
7f42775
to
e9721c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
This PR adds support for absolute paths to format schema file, for example:
Absolute paths are only allowed on client, server throws an exception if it receives from client an absolute path like this.