Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http buffer retries #42224

Merged
merged 4 commits into from Nov 4, 2022
Merged

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Oct 10, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix retries while reading from http table engines / table function. (retrtiable errors could be retries more times than needed, non-retrialble errors resulted in failed assertion in code)

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Oct 10, 2022
@tavplubix
Copy link
Member

a user-readable short description of the changes that goes to CHANGELOG.md
Fix http buffer retries.

Please fix the changelog entry

@tavplubix tavplubix self-assigned this Oct 10, 2022
@tavplubix
Copy link
Member

Also it would be great to add a test if possible

@kssenii
Copy link
Member Author

kssenii commented Nov 3, 2022

Also it would be great to add a test if possible

Added in the last commit.

@kssenii
Copy link
Member Author

kssenii commented Nov 4, 2022

Integration tests (release) [1/2] — fail: 1

test_tcp_handler_interserver_listen_host/test_case.py::test_request_to_node_without_interserver_listen_host

Stress test (tsan) — Sanitizer assert (in stderr.log)

Known issue:

WARNING: ThreadSanitizer: thread leak (pid=1434)
  Thread T231 (tid=1678, finished) created by thread T228 at:
    #0 pthread_create <null> (clickhouse+0xb9edebd) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #1 std::__1::__libcpp_thread_create[abi:v15003](unsigned long*, void* (*)(void*), void*) build_docker/../contrib/libcxx/include/__threading_support:376:10 (clickhouse+0x21f71937) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #2 std::__1::thread::thread<void (&)(), void>(void (&)()) build_docker/../contrib/libcxx/include/thread:311:16 (clickhouse+0x21f71937)
    #3 Azure::Core::Http::_detail::CurlConnectionPool::MoveConnectionBackToPool(std::__1::unique_ptr<Azure::Core::Http::CurlNetworkConnection, std::__1::default_delete<Azure::Core::Http::CurlNetworkConnection>>, Azure::Core::Http::HttpStatusCode) build_docker/../contrib/azure/sdk/core/azure-core/src/http/curl/curl.cpp:1491:21 (clickhouse+0x21f6f4bc) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #4 Azure::Core::Http::CurlSession::~CurlSession() build_docker/../contrib/azure/sdk/core/azure-core/src/http/curl/curl_session_private.hpp:393:59 (clickhouse+0x21f71ea7) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #5 Azure::Core::Http::CurlSession::~CurlSession() build_docker/../contrib/azure/sdk/core/azure-core/src/http/curl/curl_session_private.hpp:384:5 (clickhouse+0x21f71ea7)
    #6 std::__1::default_delete<Azure::Core::IO::BodyStream>::operator()[abi:v15003](Azure::Core::IO::BodyStream*) const build_docker/../contrib/libcxx/include/__memory/unique_ptr.h:48:5 (clickhouse+0x21f5c430) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #7 std::__1::unique_ptr<Azure::Core::IO::BodyStream, std::__1::default_delete<Azure::Core::IO::BodyStream>>::reset[abi:v15003](Azure::Core::IO::BodyStream*) build_docker/../contrib/libcxx/include/__memory/unique_ptr.h:305:7 (clickhouse+0x21f5c430)
    #8 std::__1::unique_ptr<Azure::Core::IO::BodyStream, std::__1::default_delete<Azure::Core::IO::BodyStream>>::~unique_ptr[abi:v15003]() build_docker/../contrib/libcxx/include/__memory/unique_ptr.h:259:19 (clickhouse+0x21f5c430)
    #9 Azure::Core::Http::Policies::_internal::TransportPolicy::Send(Azure::Core::Http::Request&, Azure::Core::Http::Policies::NextHttpPolicy, Azure::Core::Context const&) const build_docker/../contrib/azure/sdk/core/azure-core/src/http/transport_policy.cpp:79:1 (clickhouse+0x21f5c430)
    #10 Azure::Core::Http::Policies::NextHttpPolicy::Send(Azure::Core::Http::Request&, Azure::Core::Context const&) build_docker/../contrib/azure/sdk/core/azure-core/src/http/policy.cpp:21:35 (clickhouse+0x21f5a738) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)
    #11 Azure::Core::Http::Policies::_internal::LogPolicy::Send(Azure::Core::Http::Request&, Azure::Core::Http::Policies::NextHttpPolicy, Azure::Core::Context const&) const build_docker/../contrib/azure/sdk/core/azure-core/src/http/log_policy.cpp:172:23 (clickhouse+0x21f57507) (BuildId: 9f9110c5c3dbf428bd918d3a8c341106740b4128)

@kssenii kssenii merged commit ed44b20 into ClickHouse:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants