Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert #27787" #42442

Merged
merged 3 commits into from
Oct 19, 2022
Merged

Revert "Revert #27787" #42442

merged 3 commits into from
Oct 19, 2022

Conversation

KochetovNicolai
Copy link
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Expected to be fixed after #42319

This reverts commit c1cc04d.
@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Oct 18, 2022
{
from = nullable_from->getNestedType().get();
from = nullable_from ? nullable_from->getNestedType().get() : from;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing comments.

@alexey-milovidov alexey-milovidov self-assigned this Oct 18, 2022
@KochetovNicolai KochetovNicolai merged commit 010cdeb into master Oct 19, 2022
@KochetovNicolai KochetovNicolai deleted the revert-revert-27787 branch October 19, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-not-for-changelog This PR should not be mentioned in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants