Optimize cluster node list change but DirectoryMonitor can't sense it

[zhongyuankai]

Changelog category (leave one):

• Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Make inserts into distributed tables handle updated cluster configuration properly. When the list of cluster nodes is dynamically updated, the Directory Monitor of the distribution table cannot sense the new node, and the Directory Monitor must be re-noded to sense it.

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

[zhongyuankai]

Can you help with the review?

[azat]

This PR had been lost, but it looks good to me (except for minor comments, and you will need to rebase on top master, since there was some refactoring in this place), I hope that you will have to finish it!
And it definitely needs an integration test.

[zhongyuankai]

@azat ok, I will continue to complete it if necessary

[zhongyuankai]

@azat I need help. During the process of writing integration tests, if nodes are dynamically brought online or offline

[azat]

I guess you don't actually need to change their online/offline status, change remote_servers should be enough (if I'm not missing anything).

But you want to change online/offline, you can use node.stop_clickhouse() helper (for this you need also create cluster with keep_alive), but I haven't checked the code during writing this, so maybe there are some differences

[zhongyuankai]

I guess you don't actually need to change their online/offline status, change remote_servers should be enough (if I'm not missing anything).

Thank you very much for your reply, i have added an integration test, can you help me review it?

[azat]

Sorry for the delay (was on vacation), LGTM

[robot-ch-test-poll4]

This is an automated comment for commit beabc52 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks

Check name	Description	Status
AST fuzzer	Runs randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help	✅ success
CI running	A meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR	✅ success
ClickHouse build check	Builds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process	✅ success
Compatibility check	Checks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help	✅ success
Docker image for servers	The check to build and optionally push the mentioned image to docker hub	✅ success
Fast test	Normally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here	✅ success
Flaky tests	Checks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc	✅ success
Install packages	Checks that the built packages are installable in a clear environment	✅ success
Integration tests	The integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests	✅ success
Mergeable Check	Checks if all other necessary checks are successful	✅ success
Performance Comparison	Measure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests	✅ success
Push to Dockerhub	The check for building and pushing the CI related docker images to docker hub	✅ success
SQLTest	There's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS	✅ success
SQLancer	Fuzzing tests that detect logical bugs with SQLancer tool	✅ success
Sqllogic	Run clickhouse on the sqllogic test set against sqlite and checks that all statements are passed	✅ success
Stateful tests	Runs stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	✅ success
Stress test	Runs stateless functional tests concurrently from several clients to detect concurrency-related errors	✅ success
Style Check	Runs a set of checks to keep the code style clean. If some of tests failed, see the related log from the report	✅ success
Unit tests	Runs the unit tests for different release types	✅ success
Upgrade check	Runs stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts	✅ success

Check name	Description	Status
Stateless tests	Runs stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc	❌ failure

[azat]

Docs Check — expect adding docs for pr-feature
Style Check — Check black failed.

@zhongyuankai can you please fix this

[zhongyuankai]

@azat Thanks for your reply, I will fix it.

[azat]

Docs Check — expect adding docs for pr-feature

Still an issue, but let's just change the changelog entry to Improvement (it does not requires documentation)

[azat]

Integration tests flaky check (asan) — Failed tests found: error: 0, passed: 0, fail: 1, skipped: 0, broken: 0, not_fail: 0

New test fails

[zhongyuankai]

Stateless tests (release, analyzer) — fail: 2, passed: 5880, skipped: 9

@azat Already fixed, this failure should have nothing to do with changes.

[azat]

Integration tests flaky check (asan) — Failed tests found: error: 2, passed: 0, fail: 0, skipped: 0, broken: 0, not_fail: 0

Looks like internal CI issue - #56108

[azat]

LGTM. Now someone from the official team should take a look, let's ask @alexey-milovidov

[antaljanosbenjamin]

Just one minor change and I think it is good to go! Thank you @azat for catching issues and doing the review!