Add time function toStartOfInterval(). #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitlibar
force-pushed
the
add-function-to-start-of-interval
branch
5 times, most recently
from
2dbee06
to
a850ce5
Compare
vitlibar
force-pushed
the
add-function-to-start-of-interval
branch
from
a850ce5
to
0dd1dc2
Compare
vitlibar
changed the title
vitlibar
commented
Feb 11, 2019
| time_t date = find(t).date; | ||
| return date + (t - date) / 600 * 600; | ||
| } | ||
| inline time_t toStartOfTenMinutes(time_t t) const { return t / 600 * 600; } |
There was a problem hiding this comment.
Fixed to be more consistent with other toStartOf*Minutes() functions and to produce equal results with toStartOfInterval(t, INTERVAL 10 minute).
alexey-milovidov
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
#1201
This PR adds a new function
toStartOfInterval(time_or_data, INTERVAL x unit [, time_zone]),where
unitis one of the interval units (year,quarter,month,week,day,hour,minute,second).Example:
This function is a generalization of specific
toStartOf<Unit>()functions, and it returns the same results, i.e.toStartOfInterval(t, INTERVAL 1 year)returns the same astoStartOfYear(t),toStartOfInterval(t, INTERVAL 1 month)returns the same astoStartOfMonth(t),toStartOfInterval(t, INTERVAL 1 day)returns the same astoStartOfDay(t),toStartOfInterval(t, INTERVAL 15 minute)returns the same astoStartOfFifteenMinutes(t),and so on.