New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make system.replicas
parallel
#43998
Make system.replicas
parallel
#43998
Conversation
Also consider using MultiRead requests in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments above
a750d4e
to
1e67f34
Compare
1e67f34
to
fef57b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now, but it would be great to optimize StorageReplicatedMergeTree::getStatus
as well
From the code of |
Exists can be replaced with Get and error code check |
It was not necessary to merge master and restart CI |
8fe3c73
to
673ba76
Compare
Integration tests (asan) [2/6] - #44928 and #44908 Stress test (ubsan) - #45251, also there are tons of errors like
so I guess it's the "deadlock" in OvercommitTracker (#45236) |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make
system.replicas
table do parallel fetches of replicas statuses. Closes #43918