New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record server startup time in ProfileEvents #45250
Conversation
Implementation: * Added ProfileEvents::ServerStartupTime. * Recorded time from start of main till listening to sockets. Testing: * Added a test 02532_profileevents_server_startup_time.sql
…ds - Record server startup time in ProfileEvents
Do you know if internal port is up before we accept external http/native connections? I had an integration test(#45156) where it was important to check it is up. |
It's ok to have a single event for the time when all the listeners are up. |
Still, do we guarantee that all listeners are up when we write those? What is the order of endpoint initialization? How can you check that all are ready - just OK on http or native will not work and query event is inadequate. |
They are initialized in a sequence and are ready at similar times (except the embedded Keeper, but it does not matter). It's ok if the metric overestimates the startup time a little. Therefore, let's record the time after starting the last of the listeners. |
…nd added stopping the StopWatch - Record server startup time in ProfileEvents
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Record server startup time in ProfileEvents resolves #43188
Implementation:
Testing: