Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StorageIceberg and table function iceberg #45384

Merged
merged 44 commits into from Feb 17, 2023
Merged

Conversation

ucasfl
Copy link
Collaborator

@ucasfl ucasfl commented Jan 18, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add StorageIceberg and table function iceberg to access iceberg table store on S3.

@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-feature Pull request with new product feature label Jan 18, 2023
@ucasfl ucasfl changed the title Iceberg Add StorageIceberg and table function iceberg Jan 18, 2023
@kssenii kssenii self-assigned this Jan 18, 2023
src/TableFunctions/TableFunctionIceberg.cpp Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.cpp Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.cpp Outdated Show resolved Hide resolved
@ucasfl ucasfl requested a review from kssenii January 29, 2023 15:11
src/TableFunctions/ITableFunctionDataLake.h Outdated Show resolved Hide resolved
src/TableFunctions/ITableFunctionDataLake.h Outdated Show resolved Hide resolved
src/TableFunctions/ITableFunctionDataLake.h Show resolved Hide resolved
src/Storages/StorageIceberg.h Outdated Show resolved Hide resolved
@didip
Copy link

didip commented Feb 15, 2023

What an amazing effort! I hope that this will be merged soon!

src/TableFunctions/ITableFunctionDataLake.h Outdated Show resolved Hide resolved
src/TableFunctions/ITableFunctionDataLake.h Outdated Show resolved Hide resolved
src/Storages/StorageS3.h Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.h Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.h Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.h Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.cpp Outdated Show resolved Hide resolved
src/Storages/IStorageDataLake.h Outdated Show resolved Hide resolved
src/Storages/StorageIceberg.cpp Show resolved Hide resolved
src/Storages/StorageS3.cpp Outdated Show resolved Hide resolved
@kssenii kssenii merged commit bda4c94 into ClickHouse:master Feb 17, 2023
@ucasfl ucasfl deleted the iceberg branch February 18, 2023 03:29
@nickitat
Copy link
Member

build without Avro is broken. let's fix or revert

@ucasfl
Copy link
Collaborator Author

ucasfl commented Feb 18, 2023

build without Avro is broken. let's fix or revert

It's because the metadata of Iceberg is Avro format, so I need Avro to parse the metadata.

@azat
Copy link
Collaborator

azat commented Feb 18, 2023

I've also hit by this, @ucasfl any PR?

@Samrose-Ahmed
Copy link

Excuse my ignorance but why does the code do listFiles on S3, is that just a scrappy V0 impl, Iceberg shouldn't require any listing, just following the metadata files.

@ucasfl
Copy link
Collaborator Author

ucasfl commented Feb 19, 2023

Excuse my ignorance but why does the code do listFiles on S3, is that just a scrappy V0 impl, Iceberg shouldn't require any listing, just following the metadata files.

Because we don't have Iceberg C++ API.

@ucasfl
Copy link
Collaborator Author

ucasfl commented Feb 20, 2023

build without Avro is broken. let's fix or revert

@nickitat Fixed in #46554.

@rice668
Copy link

rice668 commented Feb 7, 2024

By the way, do we also consider supporting Iceberg tables stored in HDFS ?

@kssenii
Copy link
Member

kssenii commented Feb 7, 2024

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants