New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Continue of #42008, rewrite countDistinctIf with count_distinct_implementation #46051
Conversation
It is already implemented in migration pull request, and it cannot be implemented in CustomizeFunctionsPass, because there are potential issues with multiple arguments https://github.com/ClickHouse/ClickHouse/pull/45461/files#diff-377c0cb9048fe3fe24b9501a4d6fdadde00a04c75a162f705de66cadeb654d9cR4745. |
We can continue; just leave only the non-analyzer implementation. |
This is an automated comment for commit 6f88fc2 with description of existing statuses. It's updated for the latest CI running
|
@ucasfl HDFS has failed: https://s3.amazonaws.com/clickhouse-test-reports/46051/5af3689a8f15c8c9767d56e7201b73b5fe2460ba/integration_tests__asan__[3_6].html It is probably unrelated to your PR, but has to be investigated. |
6fc0567
to
6de5127
Compare
All green finally! |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add setting
rewrite_count_distinct_if_with_count_distinct_implementation
to rewritecountDistinctIf
withcount_distinct_implementation
. Closes #30642.Documentation entry for user-facing changes