Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue of #42008, rewrite countDistinctIf with count_distinct_implementation #46051

Merged
merged 20 commits into from Aug 6, 2023

Conversation

ucasfl
Copy link
Collaborator

@ucasfl ucasfl commented Feb 5, 2023

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add setting rewrite_count_distinct_if_with_count_distinct_implementation to rewrite countDistinctIf with count_distinct_implementation. Closes #30642.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@kitaisreal kitaisreal self-assigned this Feb 5, 2023
@kitaisreal
Copy link
Collaborator

It is already implemented in migration pull request, and it cannot be implemented in CustomizeFunctionsPass, because there are potential issues with multiple arguments https://github.com/ClickHouse/ClickHouse/pull/45461/files#diff-377c0cb9048fe3fe24b9501a4d6fdadde00a04c75a162f705de66cadeb654d9cR4745.
Better to remove analyzer implementation, and wait until #45461 will be merged.
Related to AST optimization, we can merge it.

@ucasfl ucasfl marked this pull request as draft February 15, 2023 07:09
@ucasfl ucasfl closed this Jul 22, 2023
@alexey-milovidov
Copy link
Member

We can continue; just leave only the non-analyzer implementation.

@robot-ch-test-poll4
Copy link
Contributor

robot-ch-test-poll4 commented Jul 22, 2023

This is an automated comment for commit 6f88fc2 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🟢 success

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🟢 success
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

@ucasfl ucasfl marked this pull request as ready for review July 22, 2023 17:52
@alexey-milovidov alexey-milovidov self-assigned this Jul 25, 2023
@alexey-milovidov
Copy link
Member

@ucasfl HDFS has failed: https://s3.amazonaws.com/clickhouse-test-reports/46051/5af3689a8f15c8c9767d56e7201b73b5fe2460ba/integration_tests__asan__[3_6].html

It is probably unrelated to your PR, but has to be investigated.

@ucasfl ucasfl added can be tested Allows running workflows for external contributors force tests Force test ignoring fast test output. labels Jul 27, 2023
@ucasfl
Copy link
Collaborator Author

ucasfl commented Aug 6, 2023

All green finally!

@alexey-milovidov alexey-milovidov merged commit 7886e06 into ClickHouse:master Aug 6, 2023
278 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors force tests Force test ignoring fast test output. pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

countDistinctIf with Date use much more memory than UInt16
6 participants