New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for MongoDB Replica Set URI with readPreference and host:port enum in MongoDB dictionaries #46524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kssenii
added
the
can be tested
Allows running workflows for external contributors
label
Feb 17, 2023
robot-clickhouse-ci-2
added
the
pr-improvement
Pull request with some product improvements
label
Feb 17, 2023
kssenii
reviewed
Feb 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix CI checks. See fast test
failed with "Cannot build ClickHouse". You can see details in details
button, press run.log
there.
You will find why build fails:
base/poco/MongoDB/CMakeFiles/_poco_mongodb.dir/src/Connection.cpp.o -c /ClickHouse/base/poco/MongoDB/src/Connection.cpp
2023-02-20 15:30:47 /ClickHouse/base/poco/MongoDB/src/Connection.cpp:240:19: error: declaration shadows a local variable [-Werror,-Wshadow]
2023-02-20 15:30:47 Poco::URI theURI(newURI);
2023-02-20 15:30:47 ^
2023-02-20 15:30:47 /ClickHouse/base/poco/MongoDB/src/Connection.cpp:198:15: note: previous declaration is here
2023-02-20 15:30:47 Poco::URI theURI(newURI);
2023-02-20 15:30:47
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
|
|
kssenii
reviewed
Mar 2, 2023
kssenii
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
can be tested
Allows running workflows for external contributors
pr-improvement
Pull request with some product improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):