Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip hardlinking inverted index files in mutation #47663

Merged
merged 3 commits into from Oct 9, 2023

Conversation

cangyin
Copy link
Contributor

@cangyin cangyin commented Mar 17, 2023

In mutation task, files that are not affected are hardlinked into new part, for wide part.

as I understand, If the inverted index be recalculated, their files should not be linked to the new part.

Close #47393

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

fix invalid segment id bug after mutation

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023

CLA assistant check
All committers have signed the CLA.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Mar 17, 2023
@ucasfl ucasfl added the can be tested Allows running workflows for external contributors label Mar 17, 2023
@cangyin cangyin force-pushed the fix-invalid-segment-id branch 3 times, most recently from 1924db4 to c9bff50 Compare March 17, 2023 13:46
@cangyin
Copy link
Contributor Author

cangyin commented Mar 18, 2023

some tests failed, but looks irrelavant. what should I do next ?

skip hardlinking inverted index files in mutation
@cangyin
Copy link
Contributor Author

cangyin commented Mar 18, 2023

finally, all checks turned green in actions page https://github.com/ClickHouse/ClickHouse/actions/runs/4454242025/jobs/7825239544

but a 'Stress test (debug)' in this PR page is failing, is that ok ?

@alexey-milovidov
Copy link
Member

The reports of our CI have poor usability for the following reasons:

  1. The checks are run with GitHub Actions on "spot" (interruptible) instances in AWS. When the instance where the test is run is interrupted, it will be shown as "PullRequestCI" failure, but the check will be restarted. A few hours after the commit, you will see annoying and misleading failed checks from the "PullRequestCI", that are restarted and fixed automatically.

  2. Every check is presented in the list on GitHub twice: as a GitHub Actions run (like "PullRequestCI ...", usually located at top) and as a generated report to look (like "ClickHouse build check"). The generated report presents the test results, while the PullRequestCI presents the GitHub actions logs.

  3. There are dependencies between checks - for example, if Fast Test fails, the more heavy Build Check will not run, but in this case, a report like "ClickHouse build check — 0/8 artifact groups are OK (0 of 8 builds are OK)" will be published, but it does not give any information, and it's even misleading (you can click there by mistake and waste a minute of your time).

These reasons make me sorry for the fact that the new external contributors are overwhelmed by the reports that are looking randomly and don't know where to look for the proper results.
Note: it is still perfectly usable if you know where to click and get used to it; and in fact, our CI is (as far as I know) the most powerful among open-source with publicly available results.

To overcome the poor usability of GitHub actions and to fix this problem, @Felixoid is going to try to introduce a summary of the checks in a comment with a report, that will be updated automatically.

@cangyin
Copy link
Contributor Author

cangyin commented Mar 19, 2023

seems ClickHouse may need a better way to handle additional files for a index.

@cangyin
Copy link
Contributor Author

cangyin commented Mar 22, 2023

@alexey-milovidov @rschu1ze Thanks for taking the time to review my PR. I was wondering if there are any outstanding issues that need to be addressed, and when I can expect a decision on whether or not it will be merged ?

@robot-clickhouse-ci-2
Copy link
Contributor

robot-clickhouse-ci-2 commented Oct 8, 2023

This is an automated comment for commit 1c473c0 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Successful checks
Check nameDescriptionStatus
Bugfix validate checkChecks that either a new test (functional or integration) or there some changed tests that fail with the binary built on master branch✅ success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Mergeable CheckChecks if all other necessary checks are successful✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub✅ success
SQLTestThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool✅ success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts❌ failure

@alexey-milovidov alexey-milovidov merged commit e633f36 into ClickHouse:master Oct 9, 2023
274 of 277 checks passed
@cangyin
Copy link
Contributor Author

cangyin commented Oct 10, 2023

Thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-bugfix Pull request with bugfix, not backported by default
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inverted index bug on segment id
7 participants