New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
skip hardlinking inverted index files in mutation #47663
skip hardlinking inverted index files in mutation #47663
Conversation
1924db4
to
c9bff50
Compare
some tests failed, but looks irrelavant. what should I do next ? |
skip hardlinking inverted index files in mutation
c093f4c
to
51ea088
Compare
finally, all checks turned green in actions page https://github.com/ClickHouse/ClickHouse/actions/runs/4454242025/jobs/7825239544 but a 'Stress test (debug)' in this PR page is failing, is that ok ? |
The reports of our CI have poor usability for the following reasons:
These reasons make me sorry for the fact that the new external contributors are overwhelmed by the reports that are looking randomly and don't know where to look for the proper results. To overcome the poor usability of GitHub actions and to fix this problem, @Felixoid is going to try to introduce a summary of the checks in a comment with a report, that will be updated automatically. |
seems ClickHouse may need a better way to handle additional files for a index. |
@alexey-milovidov @rschu1ze Thanks for taking the time to review my PR. I was wondering if there are any outstanding issues that need to be addressed, and when I can expect a decision on whether or not it will be merged ? |
This is an automated comment for commit 1c473c0 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page Successful checks
|
Thanks for helping! |
In mutation task, files that are not affected are hardlinked into new part, for wide part.
as I understand, If the inverted index be recalculated, their files should not be linked to the new part.
Close #47393
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
fix invalid segment id bug after mutation