Some fixes for parallel replicas #48433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+466
to
+470
| bool is_query_with_final = false; | ||
| if (query_info.table_expression_modifiers) | ||
| is_query_with_final = query_info.table_expression_modifiers->hasFinal(); | ||
| else if (query_info.query) | ||
| is_query_with_final = query_info.query->as<ASTSelectQuery &>().final(); |
There was a problem hiding this comment.
ReadFromMergeTree::isFinal(const SelectQueryInfo & query_info)?
There was a problem hiding this comment.
Copied from there, yes 😜
KochetovNicolai
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
allow_experimental_parallel_reading_from_replicasto 1 some queries could end up with an error likecolumn in not find a block. This is now fixed. Closes: Attempting to upgrade to 23.2 or 23.3.. version results in Not found column count() in block on aggregations #48367LOGICAL_ERRORtoSUPPORT_IS_DISABLEDwhen we see that there is a query with FINAL modifier and parallel replicas deep inside the code. While we will try to execute a query without parallel replicas in that case, the user may still receive such an error. Closes: Logical error: Final modifier is not supported with parallel replicas #48302