Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keeper bench 2.0 #48547

Merged
merged 16 commits into from May 1, 2023
Merged

Keeper bench 2.0 #48547

merged 16 commits into from May 1, 2023

Conversation

antonio2368
Copy link
Member

@antonio2368 antonio2368 commented Apr 7, 2023

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

New and improved keeper-bench.
Everything can be customized from yaml/XML file:

  • request generator
    • each type of request generator can have a specific set of fields
    • multi requests can be generated just by doing the same under multi key
    • for each request or subrequest in multi a weight field can be defined to control distribution
  • define trees that need to be setup for a test run
  • hosts can be defined with all timeouts customizable and it's possible to control how many sessions to generate for each host
  • integers defined with min_value and max_value fields are random number generators

There is an example of a configuration in utils/keeper-bench/example.yaml.

Things left to do:

  • how to generate results?
  • what data to collect (throughput, latency...)
  • Update README with everything explained

cc @alesapin @qoega

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-build Pull request with build/testing/packaging improvement label Apr 7, 2023
@antonio2368 antonio2368 changed the title [WIP] Keeper bench 2.0 Keeper bench 2.0 Apr 17, 2023
@antonio2368 antonio2368 marked this pull request as ready for review April 17, 2023 14:12
@alesapin alesapin self-assigned this Apr 21, 2023
@alesapin alesapin merged commit 49a7eb7 into master May 1, 2023
255 of 256 checks passed
@alesapin alesapin deleted the keeper-bench-2.0 branch May 1, 2023 12:48
@pufit
Copy link
Member

pufit commented May 1, 2023

This commit broke for me the build on MacOS with -DENABLE_LIBRARIES=0 :(

CMake Error at utils/keeper-bench/CMakeLists.txt:2 (target_link_libraries):
  Target "keeper-bench" links to:

    ch_contrib::rapidjson

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-build Pull request with build/testing/packaging improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants