New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zookeeper name in system.replicas #48549
add zookeeper name in system.replicas #48549
Conversation
8518123
to
6cba6c0
Compare
Ok. Need to add a test, see |
Need to add a test. |
sorry for being late, i 'm busy at work recently. |
6cba6c0
to
a929179
Compare
Ok. Now we need a changelog entry "a user-readable short description of the changes that goes to CHANGELOG.md" |
there is the Change entry. |
4ded7ff
to
cf8c9f3
Compare
But it is difficult to understand - we need to write what, and why. |
see. (chrome spell check now becomes useful to me :) |
failing at CRLF again. |
cf8c9f3
to
12f1ee6
Compare
some checks failed, seems irrelevant |
12f1ee6
to
623c8db
Compare
INSERT INTO t1 SELECT * FROM generateRandom('k UInt32, v UInt32') LIMIT 1; | ||
INSERT INTO t2 SELECT * FROM generateRandom('k UInt32, v UInt32') LIMIT 1; | ||
|
||
SELECT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That requst is flaky
Fail in master, for example.
https://s3.amazonaws.com/clickhouse-test-reports/35827/248e8819ff2c5fb9b78f32f8f0199f77c9a841b0/stateless_tests__debug__[5_5].html
Order by needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would be useful for queries like:
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a new column
zookeeper_name
in system.replicas, to indicate on which (auxiliary) zookeeper cluster the replicated table's metadata is stored.