Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add zookeeper name in system.replicas #48549

Merged
merged 2 commits into from Apr 26, 2023

Conversation

cangyin
Copy link
Contributor

@cangyin cangyin commented Apr 7, 2023

this would be useful for queries like:

SELECT
    zookeeper_name,
    count()
FROM system.replicas
INNER JOIN system.parts USING (database, table)
WHERE database = 'business'
GROUP BY zookeeper_name
ORDER BY count() ASC

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Add a new column zookeeper_name in system.replicas, to indicate on which (auxiliary) zookeeper cluster the replicated table's metadata is stored.

@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-improvement Pull request with some product improvements label Apr 7, 2023
@alexey-milovidov alexey-milovidov added the can be tested Allows running workflows for external contributors label Apr 9, 2023
@alexey-milovidov
Copy link
Member

Ok. Need to add a test, see tests/queries/0_stateless.

@alexey-milovidov alexey-milovidov self-assigned this Apr 9, 2023
@alexey-milovidov
Copy link
Member

Need to add a test.

@cangyin
Copy link
Contributor Author

cangyin commented Apr 14, 2023

sorry for being late, i 'm busy at work recently.

@alexey-milovidov
Copy link
Member

Ok. Now we need a changelog entry "a user-readable short description of the changes that goes to CHANGELOG.md"

@cangyin
Copy link
Contributor Author

cangyin commented Apr 23, 2023

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

add zookeeper name in system.replicas

there is the Change entry.

@alexey-milovidov
Copy link
Member

But it is difficult to understand - we need to write what, and why.

@cangyin
Copy link
Contributor Author

cangyin commented Apr 23, 2023

see. (chrome spell check now becomes useful to me :)

@cangyin
Copy link
Contributor Author

cangyin commented Apr 23, 2023

failing at CRLF again.

@cangyin
Copy link
Contributor Author

cangyin commented Apr 24, 2023

some checks failed, seems irrelevant

@alexey-milovidov alexey-milovidov merged commit 354cf09 into ClickHouse:master Apr 26, 2023
160 of 210 checks passed
@cangyin cangyin deleted the add_zookeeper_name branch April 26, 2023 23:13
INSERT INTO t1 SELECT * FROM generateRandom('k UInt32, v UInt32') LIMIT 1;
INSERT INTO t2 SELECT * FROM generateRandom('k UInt32, v UInt32') LIMIT 1;

SELECT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
can be tested Allows running workflows for external contributors pr-improvement Pull request with some product improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants