Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1) #48670

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Remove lock for duplicated parts UUIDs (allow_experimental_query_deduplication=1) #48670

merged 1 commit into from
Apr 12, 2023

Commits on Apr 11, 2023

  1. Remove lock for duplicated parts UUIDs (allow_experimental_query_dedu… 

    …plication=1)

It looks redundant, since sendQuery() cannot be executed in parallel
with processPacket() (hence RemoteQueryExecutor::setPartUUIDs())

This likely will fix the lock-order-inversion in RemoteQueryExecutor,
since I think it is false-positive.

Fixes: ClickHouse#48534
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
    @azat
    azat committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    d7f8650 View commit details
    Browse the repository at this point in the history