New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QueryCache: Support queries with totals and extremes #48853
Conversation
5fa3a98
to
3dfa9c7
Compare
Looks like I made pretty much every mistake with pipeline processors one can make (at least I learned something) but the latest version seems to work. Let me rebase, cleanup and add a test. |
8061eb1
to
674cbc4
Compare
@nickitat You are the only reviewer I can think of for this PR. Would you like to have a look? Thanks! The logic is admittedly a bit tricky. In case of questions, please ask. |
674cbc4
to
b565257
Compare
@rschu1ze, is it related to the query cache? |
This is an automated comment for commit bba85c9 with description of existing statuses. It's updated for the latest CI running
|
0c49cfa
to
32dde2a
Compare
32dde2a
to
945a513
Compare
@@ -146,11 +147,15 @@ class QueryCache | |||
{ | |||
public: | |||
bool hasCacheEntryForKey() const; | |||
Pipe && getPipe(); /// must be called only if hasCacheEntryForKey() returns true | |||
std::unique_ptr<SourceFromChunks> getSource(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a comment that these methods shouldn't be called more then once
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks.
ClickHouse Stateless Tests (release, Wide Parts Enabled):
ClickHouse Stateless Tests (release, Analyzer)
ClickHouse Integration Tests (release) [2/4]
|
--> #49594 |
Fixes: #48677
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
The query cache can now supports queries with totals and extremes modifier.