Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SHOW INDEX #49158

Merged
merged 9 commits into from May 6, 2023
Merged

Implement SHOW INDEX #49158

merged 9 commits into from May 6, 2023

Conversation

rschu1ze
Copy link
Member

@rschu1ze rschu1ze commented Apr 25, 2023

Fixes #49140

The implementation is modeled after MySQL's SHOW INDEX. This leads to some weird naming and a few unused fields ...

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Support statement SHOW INDEX to improve compatibility with MySQL

@robot-ch-test-poll robot-ch-test-poll added the pr-feature Pull request with new product feature label Apr 25, 2023
<< "primary_key AS expression "
<< "FROM system.tables "
<< "WHERE "
<< "database = '" << database << "' "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL injection.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried a few injection attacks from here but either the parser rejected such queries or there was an error when the rewritten query was executed.

What worked was an attack with 1=1, e.g. show columns from tbl where field = 'b' or 1=1. Since we would still be limited to system tables and not expose arbitrary table data, that should be okay as behavior.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just put into backQuoteIfNeed

@robot-ch-test-poll3
Copy link
Contributor

robot-ch-test-poll3 commented May 2, 2023

This is an automated comment for commit f7e31a9 with description of existing statuses. It's updated for the latest CI running
The full report is available here
The overall status of the commit is 🔴 failure

Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help🟢 success
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR🟢 success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process🟢 success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help🟢 success
Docker image for serversThe check to build and optionally push the mentioned image to docker hub🟢 success
Docs CheckBuilds and tests the documentation🟢 success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here🟢 success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc🟢 success
Install packagesChecks that the built packages are installable in a clear environment🟢 success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests🔴 failure
Mergeable CheckChecks if all other necessary checks are successful🟢 success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests🟢 success
Push to DockerhubThe check for building and pushing the CI related docker images to docker hub🟢 success
SQLancerFuzzing tests that detect logical bugs with SQLancer tool🟢 success
SqllogicRun clickhouse on the sqllogic test set against sqlite and checks that all statements are passed🟢 success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🟢 success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc🔴 failure
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors🟢 success
Style CheckRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report🟢 success
Unit testsRuns the unit tests for different release types🟢 success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts🟢 success

primary_key AS expression
FROM system.tables
WHERE
database = '{0}'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQL injection.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test with the database name and table name containing the ' character.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parsers of SHOW INDEX and SHOW COLUMNS expect database and table as identifiers, whereas WHERE table/database = expects a string literal. The mismatch is now properly resolved using quoting. I have also added a test.

@alexey-milovidov
Copy link
Member

Ok. There are also manipulators escape and quote in Operators.h

@rschu1ze
Copy link
Member Author

rschu1ze commented May 5, 2023

Ok. There are also manipulators escape and quote in Operators.h

Sure, I just found it more readable to write the generated SELECT query using with as little abstractions as possible.

@alexey-milovidov
Copy link
Member

Ok. While the safest way is AST construction.

@rschu1ze
Copy link
Member Author

rschu1ze commented May 6, 2023

Test failures also occur in master --> merging

@rschu1ze rschu1ze merged commit 7137c88 into master May 6, 2023
266 of 268 checks passed
@rschu1ze rschu1ze deleted the rs/show-indexes branch May 6, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature Pull request with new product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MySQL compatibility: SHOW KEYS
4 participants