New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection options for MongoDB dictionaries #49225
Conversation
6f43812
to
ca68cd8
Compare
// Connect with host/port/user/etc. | ||
connection->connect(host, port); | ||
// Connect with host/port/user/etc through constructing | ||
std::string uri_constructed("mongodb://" + host + ":" + std::to_string(port) + "/" + db + "?" + options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
std::string uri_constructed("mongodb://" + host + ":" + std::to_string(port) + "/" + db + "?" + options); | |
std::string uri_constructed("mongodb://" + host + ":" + std::to_string(port) + "/" + db + (options.empty() ? "" : "?" + options)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in commit.
test_merge_tree_s3/test.py::test_store_cleanup_disk_s3 - not related to changes |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Enable connection options for the MongoDB dictionary.
Example:
Documentation entry for user-facing changes